Support for database collations (part of #1050).

Author: cincuranet

src/FirebirdSql.EntityFrameworkCore.Firebird/Migrations/FbMigrationsSqlGenerator.cs

@@ -16,13 +16,14 @@
 //$Authors = Jiri Cincura (jiri@cincura.net)
 
 using System;
+using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
 using FirebirdSql.Data.FirebirdClient;
 using FirebirdSql.EntityFrameworkCore.Firebird.Infrastructure.Internal;
 using FirebirdSql.EntityFrameworkCore.Firebird.Metadata;
 using FirebirdSql.EntityFrameworkCore.Firebird.Metadata.Internal;
-using FirebirdSql.EntityFrameworkCore.Firebird.Migrations.Operations;
+using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Migrations;
 using Microsoft.EntityFrameworkCore.Migrations.Operations;
@@ -46,12 +47,6 @@ protected override void Generate(MigrationOperation operation, IModel model, Mig
 	{
 		switch (operation)
 		{
-			case FbCreateDatabaseOperation createDatabaseOperation:
-				Generate(createDatabaseOperation, model, builder);
-				break;
-			case FbDropDatabaseOperation dropDatabaseOperation:
-				Generate(dropDatabaseOperation, model, builder);
-				break;
 			default:
 				base.Generate(operation, model, builder);
 				break;
@@ -309,23 +304,6 @@ protected override void Generate(EnsureSchemaOperation operation, IModel model,
 		=> throw new NotSupportedException("Schemas are not supported by Firebird.");
 
 
-	public virtual void Generate(FbCreateDatabaseOperation operation, IModel model, MigrationCommandListBuilder builder)
-	{
-		if (Options.HasFlag(MigrationsSqlGenerationOptions.Script))
-			throw new NotSupportedException("Creating database from script is not supported.");
-
-		FbConnection.CreateDatabase(operation.ConnectionString, pageSize: 16384);
-	}
-
-	public virtual void Generate(FbDropDatabaseOperation operation, IModel model, MigrationCommandListBuilder builder)
-	{
-		if (Options.HasFlag(MigrationsSqlGenerationOptions.Script))
-			throw new NotSupportedException("Dropping database from script is not supported.");
-
-		FbConnection.ClearPool(operation.ConnectionString);
-		FbConnection.DropDatabase(operation.ConnectionString);
-	}
-
 	protected override void ColumnDefinition(string schema, string table, string name, ColumnOperation operation, IModel model, MigrationCommandListBuilder builder)
 	{
 		builder.Append(Dependencies.SqlGenerationHelper.DelimitIdentifier(name));

src/FirebirdSql.EntityFrameworkCore.Firebird/Migrations/Operations/FbCreateDatabaseOperation.cs

@@ -20,6 +20,8 @@
 using System.Threading.Tasks;
 using FirebirdSql.Data.FirebirdClient;
 using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Storage;
 
 namespace FirebirdSql.EntityFrameworkCore.Firebird.Storage.Internal;
@@ -39,10 +41,42 @@ public FbDatabaseCreator(RelationalDatabaseCreatorDependencies dependencies, IFb
 	public override void Create()
 	{
 		FbConnection.CreateDatabase(_connection.ConnectionString, pageSize: 16384);
+
+		var designTimeModel = Dependencies.CurrentContext.Context.GetService<IDesignTimeModel>().Model;
+
+		var collation = designTimeModel.GetCollation();
+		if (collation != null)
+		{
+			Dependencies.ExecutionStrategy.Execute(
+				_connection,
+				connection => CreateAlterCollationCommand(collation).ExecuteNonQuery(
+					new RelationalCommandParameterObject(
+						connection,
+						null,
+						null,
+						Dependencies.CurrentContext.Context,
+						Dependencies.CommandLogger)));
+		}
 	}
-	public override Task CreateAsync(CancellationToken cancellationToken = default)
+	public override async Task CreateAsync(CancellationToken cancellationToken = default)
 	{
-		return FbConnection.CreateDatabaseAsync(_connection.ConnectionString, pageSize: 16384, cancellationToken: cancellationToken);
+		await FbConnection.CreateDatabaseAsync(_connection.ConnectionString, pageSize: 16384, cancellationToken: cancellationToken).ConfigureAwait(false);
+
+		var designTimeModel = Dependencies.CurrentContext.Context.GetService<IDesignTimeModel>().Model;
+
+		var collation = designTimeModel.GetCollation();
+		if (collation != null)
+		{
+			await Dependencies.ExecutionStrategy.ExecuteAsync(
+				_connection,
+				connection => CreateAlterCollationCommand(collation).ExecuteNonQueryAsync(
+					new RelationalCommandParameterObject(
+						connection,
+						null,
+						null,
+						Dependencies.CurrentContext.Context,
+						Dependencies.CommandLogger))).ConfigureAwait(false);
+		}
 	}
 
 	public override void Delete()
@@ -76,7 +110,7 @@ public override async Task<bool> ExistsAsync(CancellationToken cancellationToken
 	{
 		try
 		{
-			await _connection.OpenAsync(cancellationToken);
+			await _connection.OpenAsync(cancellationToken).ConfigureAwait(false);
 			return true;
 		}
 		catch (FbException)
@@ -85,7 +119,7 @@ public override async Task<bool> ExistsAsync(CancellationToken cancellationToken
 		}
 		finally
 		{
-			await _connection.CloseAsync();
+			await _connection.CloseAsync().ConfigureAwait(false);
 		}
 	}
 
@@ -113,12 +147,20 @@ public override Task<bool> HasTablesAsync(CancellationToken cancellationToken =
 					null,
 					Dependencies.CurrentContext.Context,
 					Dependencies.CommandLogger),
-				ct))
+				ct).ConfigureAwait(false))
 				!= 0,
 			cancellationToken);
 	}
 
 	IRelationalCommand CreateHasTablesCommand()
 	   => _rawSqlCommandBuilder
 		   .Build("SELECT COUNT(*) FROM rdb$relations WHERE COALESCE(rdb$system_flag, 0) = 0 AND rdb$view_blr IS NULL");
-}
+
+	IRelationalCommand CreateAlterCollationCommand(string collation)
+		=> _rawSqlCommandBuilder
+			.Build($@"EXECUTE BLOCK
+AS
+BEGIN
+	execute statement 'alter character set ' || (select coalesce(trim(rdb$character_set_name), 'NONE') from rdb$database) || ' set default collation {collation}';
+END");
+}