Skip to content

Commit c198a6a

Browse files
committed
Rename db.system to db.system.name per OTel semantic conventions v1.40+
The semantic conventions renamed db.system to db.system.name. The well-known value for Firebird is 'firebirdsql', not 'firebird'. Updated in both FbActivitySource (spans) and FbConnection (metrics).
1 parent 9b25148 commit c198a6a

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbConnection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public override string ConnectionString
194194
_connectionString = value;
195195

196196
MetricsConnectionAttributes = [
197-
new("db.system", "firebird"),
197+
new("db.system.name", "firebirdsql"),
198198
new("db.namespace", _options.Database),
199199
new("server.address", $"{_options.DataSource}:{_options.Port}")
200200
];

src/FirebirdSql.Data.FirebirdClient/Trace/FbActivitySource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ internal static Activity CommandStart(FbCommand command)
4444
if (activity is not { IsAllDataRequested: true })
4545
return activity;
4646

47-
activity.SetTag("db.system", "firebird");
47+
activity.SetTag("db.system.name", "firebirdsql");
4848

4949
if (dbCollectionName != null)
5050
{

0 commit comments

Comments
 (0)