Skip to content

Commit ecdb4cd

Browse files
committed
Read ActivitySource/Meter version from assembly metadata
Replace hardcoded '1.0.0' version with the assembly's informational version, keeping the telemetry version in sync with the NuGet package.
1 parent 78c6d3b commit ecdb4cd

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/FirebirdSql.Data.FirebirdClient/Metrics/FbMetricsStore.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System.Diagnostics;
44
using System.Diagnostics.Metrics;
55
using System.Linq;
6+
using System.Reflection;
67
using FirebirdSql.Data.FirebirdClient;
78

89
namespace FirebirdSql.Data.Metrics
@@ -14,7 +15,9 @@ internal static class FbMetricsStore
1415
private const string ConnectionStateIdleValue = "idle";
1516
private const string ConnectionStateUsedValue = "used";
1617

17-
internal static readonly Meter Source = new("FirebirdSql.Data", "1.0.0");
18+
static readonly string Version = typeof(FbMetricsStore).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? "0.0.0";
19+
20+
internal static readonly Meter Source = new("FirebirdSql.Data", Version);
1821

1922
static readonly Histogram<double> OperationDuration;
2023
static readonly Histogram<double> ConnectionCreateTime;

src/FirebirdSql.Data.FirebirdClient/Trace/FbActivitySource.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,17 @@
22
using System.ComponentModel;
33
using System.Data;
44
using System.Diagnostics;
5+
using System.Reflection;
56
using FirebirdSql.Data.FirebirdClient;
67
using FirebirdSql.Data.Logging;
78

89
namespace FirebirdSql.Data.Trace
910
{
1011
internal static class FbActivitySource
1112
{
12-
internal static readonly ActivitySource Source = new("FirebirdSql.Data", "1.0.0");
13+
static readonly string Version = typeof(FbActivitySource).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? "0.0.0";
14+
15+
internal static readonly ActivitySource Source = new("FirebirdSql.Data", Version);
1316

1417
internal static Activity CommandStart(FbCommand command)
1518
{

0 commit comments

Comments
 (0)