Skip to content

Commit d73893a

Browse files
committed
Move static config in modules to constructor
See also testcontainers/testcontainers-java#2473
1 parent 039d7d8 commit d73893a

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

CHANGES.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ Version History
44
1.0.4
55
-----
66

7-
- Update org.testcontainers:jdbc to 1.14.3
7+
- Update org.testcontainers:jdbc to 1.14.3
8+
- Move static config in modules to constructor (see also https://github.com/testcontainers/testcontainers-java/pull/2473)
9+
810

911
1.0.3
1012
-----

src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ public FirebirdContainer() {
3434

3535
public FirebirdContainer(String dockerImageName) {
3636
super(dockerImageName);
37+
addExposedPort(FIREBIRD_PORT);
3738
}
3839

3940
@Override
4041
protected void configure() {
41-
addExposedPort(FIREBIRD_PORT);
4242
addEnv("TZ", timeZone);
4343
addEnv("FIREBIRD_DATABASE", databaseName);
4444

0 commit comments

Comments
 (0)