Fixed issue with transaction in R/O database reported by Adriano privately

Author: AlexPeshkoff

src/jrd/Attachment.cpp

@@ -959,6 +959,12 @@ void Attachment::createMetaTransaction(thread_db* tdbb)
 	{
 		att_meta_transaction = TRA_start(tdbb,
 			TRA_readonly | TRA_ignore_limbo | TRA_read_committed | TRA_rec_version, DEFAULT_LOCK_TIMEOUT);
+
+		if (att_meta_transaction && att_meta_transaction->tra_lock)
+		{
+			LCK_release(tdbb, att_meta_transaction->tra_lock);
+			att_meta_transaction->tra_lock = nullptr;
+		}
 	}
 }
 

src/jrd/tra.h

@@ -278,7 +278,7 @@ class jrd_tra final : public pool_alloc<type_tra>
 	ReplBlobMap tra_repl_blobs;			// map of blob IDs replicated in this transaction
 	BlobUtilMap tra_blob_util_map;		// map of blob IDs for RDB$BLOB_UTIL package
 	ArrayField*	tra_arrays;				// Linked list of active arrays
-	Lock*		tra_lock;				// lock for transaction
+	Lock*		tra_lock;				// lock for transaction - may be NULL for special transactions
 	Lock*		tra_alter_db_lock;		// lock for ALTER DATABASE statement(s)
 	vec<Lock*>*			tra_relation_locks;	// locks for relations
 	TransactionBitmap*	tra_commit_sub_trans;	// committed sub-transactions