Skip to content

Commit 8f937e9

Browse files
committed
Configure and test all Srp plugins
1 parent 3075247 commit 8f937e9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
version: '5.0.3'
1919
firebird_root_password: 'masterkey'
20-
firebird_conf: 'WireCrypt=Enabled,AuthServer=Srp256;Srp;Legacy_Auth,UserManager=Srp;Legacy_UserManager'
20+
firebird_conf: 'WireCrypt=Enabled,AuthServer=Srp256;Srp;Legacy_Auth;Srp224;Srp384;Srp512,UserManager=Srp;Legacy_UserManager'
2121
- uses: actions/checkout@v6
2222
- name: Set up Java 17
2323
uses: actions/setup-java@v5

src/test/org/firebirdsql/common/extension/RunEnvironmentExtension.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ public boolean isMet() {
9696
ALL_SRP_PLUGINS {
9797
@Override
9898
public boolean isMet() {
99-
// Enabling all SRP plugins is messy in the jacobalberty/firebird Docker image,
100-
// so assume it is not available
101-
return !DB_ON_DOCKER;
99+
// NOTE: This requirement exist for historic reasons; configuring all plugins on
100+
// the jacobalberty/firebird image was hard to do (especially using juarezr/firebirdsql-github-action)
101+
return true;
102102
}
103103
}
104104
;

0 commit comments

Comments
 (0)