Skip to content

Commit 223277f

Browse files
committed
Remove TODO
1 parent 2946f6a commit 223277f

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

ibase_query.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
| Andrew Avdeev <andy@simgts.mv.ru> |
1717
| Ard Biesheuvel <a.k.biesheuvel@its.tudelft.nl> |
1818
| Martin Koeditz <martin.koeditz@it-syn.de> |
19+
| Martins Lazdans <marrtins@dqdp.net> |
1920
| others |
2021
+----------------------------------------------------------------------+
2122
| You'll find history on Github |
@@ -864,9 +865,7 @@ static void _php_ibase_alloc_xsqlda_vars(XSQLDA *sqlda, ISC_SHORT *nullinds) /*
864865
break;
865866
#endif
866867
default:
867-
// TODO: report human readable type. Grab ints from sqlda_pub.h
868-
// and just map to char *
869-
php_error(E_WARNING, "Unhandled sqltype: %d for sqlname %s %s:%d. Probably compiled against old fbclient library (%d)", var->sqltype, var->sqlname, __FILE__, __LINE__, FB_API_VER);
868+
fbp_fatal("Unhandled sqltype: %d for sqlname %s %s:%d. Probably compiled against outdated fbclient library (%d)", var->sqltype, var->sqlname, __FILE__, __LINE__, FB_API_VER);
870869
break;
871870
} /* switch */
872871

0 commit comments

Comments
 (0)