Skip to content

Commit 8212f6f

Browse files
committed
Make TODOs more readable
1 parent 119f820 commit 8212f6f

1 file changed

Lines changed: 6 additions & 11 deletions

File tree

ibase_query.c

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -498,8 +498,7 @@ static int _php_ibase_bind_array(zval *val, char *buf, zend_ulong buf_size, /* {
498498
*(double*) buf = Z_DVAL_P(val);
499499
break;
500500
case SQL_TIMESTAMP:
501-
// TODO:
502-
// case SQL_TIMESTAMP_TZ:
501+
// TODO: case SQL_TIMESTAMP_TZ:
503502
convert_to_string(val);
504503
#ifdef HAVE_STRPTIME
505504
strptime(Z_STRVAL_P(val), INI_STR("ibase.timestampformat"), &t);
@@ -535,8 +534,7 @@ static int _php_ibase_bind_array(zval *val, char *buf, zend_ulong buf_size, /* {
535534
isc_encode_sql_date(&t, (ISC_DATE *) buf);
536535
break;
537536
case SQL_TYPE_TIME:
538-
// TODO:
539-
// case SQL_TIME_TZ:
537+
// TODO: case SQL_TIME_TZ:
540538
convert_to_string(val);
541539
#ifdef HAVE_STRPTIME
542540
strptime(Z_STRVAL_P(val), INI_STR("ibase.timeformat"), &t);
@@ -622,9 +620,8 @@ static int _php_ibase_bind(ibase_query *ib_query, zval *b_vars) /* {{{ */
622620
struct tm t;
623621

624622
case SQL_TIMESTAMP:
625-
// TODO:
626-
// case SQL_TIMESTAMP_TZ:
627-
// case SQL_TIME_TZ:
623+
// TODO: case SQL_TIMESTAMP_TZ:
624+
// TODO: case SQL_TIME_TZ:
628625
case SQL_TYPE_DATE:
629626
case SQL_TYPE_TIME:
630627
if (Z_TYPE_P(b_var) == IS_LONG) {
@@ -644,8 +641,7 @@ static int _php_ibase_bind(ibase_query *ib_query, zval *b_vars) /* {{{ */
644641
format = INI_STR("ibase.dateformat");
645642
break;
646643
case SQL_TYPE_TIME:
647-
// TODO:
648-
// case SQL_TIME_TZ:
644+
// TODO: case SQL_TIME_TZ:
649645
format = INI_STR("ibase.timeformat");
650646
}
651647
if (!strptime(Z_STRVAL_P(b_var), format, &t)) {
@@ -665,8 +661,7 @@ static int _php_ibase_bind(ibase_query *ib_query, zval *b_vars) /* {{{ */
665661
isc_encode_sql_date(&t, &buf[i].val.dtval);
666662
break;
667663
case SQL_TYPE_TIME:
668-
// TODO:
669-
// case SQL_TIME_TZ:
664+
// TODO: case SQL_TIME_TZ:
670665
isc_encode_sql_time(&t, &buf[i].val.tmval);
671666
break;
672667
}

0 commit comments

Comments
 (0)