Skip to content

Commit cb103da

Browse files
committed
Update TODO
1 parent f356ed6 commit cb103da

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

ibase_query.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ static int _php_ibase_prepare(ibase_query **new_query, ibase_db_link *link, /* {
271271
goto _php_ibase_alloc_query_error;
272272
}
273273

274+
// TODO: provide query_len
274275
if (isc_dsql_prepare(IB_STATUS, &ib_query->trans->handle, &ib_query->stmt,
275276
0, query, link->dialect, NULL)) {
276277
IBDEBUG("isc_dsql_prepare() failed\n");
@@ -900,6 +901,8 @@ static int _php_ibase_exec(INTERNAL_FUNCTION_PARAMETERS, ibase_query *ib_query,
900901
/* Have we used this cursor before and it's still open (exec proc has no cursor) ? */
901902
if (ib_query->is_open && ib_query->statement_type != isc_info_sql_stmt_exec_procedure) {
902903
IBDEBUG("Implicitly closing a cursor");
904+
// TODO: ini configurable warning
905+
// php_error_docref(NULL, E_NOTICE, "Implicitly closing a cursor");
903906
if (isc_dsql_free_statement(IB_STATUS, &ib_query->stmt, DSQL_close)) {
904907
_php_ibase_error();
905908
return FAILURE;

0 commit comments

Comments
 (0)