From 8cdb2b526dd20b63d249f27c62583daa98890882 Mon Sep 17 00:00:00 2001
From: GenericJam <genericjam@gmail.com>
Date: Tue, 2 Jun 2026 02:04:08 -0600
Subject: [PATCH] Release 0.5.16: gate plugin flags on the iOS device build
 path too
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

0.5.15 gated Android + iOS-sim but missed zig_build_binary_ios_device, which
still emitted -Dplugin_swift_files/-Dplugin_frameworks (+ generated the
bootstrap) unconditionally — so `mix mob.deploy --native` to a physical iPhone
broke on pre-plugin app scaffolding. The device path now mirrors the sim path.

Verified: mob.deploy --native to a physical iPhone → full OTP, Phoenix up,
LiveView connected, embedded Livebook home rendered.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 CHANGELOG.md                |  5 +++++
 lib/mob_dev/native_build.ex | 41 +++++++++++++++++++++++++------------
 mix.exs                     |  2 +-
 3 files changed, 34 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e3cf111..1a18a4e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,11 @@ Full module documentation: [hexdocs.pm/mob_dev](https://hexdocs.pm/mob_dev).
 
 ---
 
+## [0.5.16]
+
+### Fixed
+- **Gate the plugin flags on the iOS *device* build path too.** 0.5.15 gated the plugin-flag emission for Android and the iOS *simulator* build, but `zig_build_binary_ios_device` still emitted `-Dplugin_swift_files`/`-Dplugin_frameworks` (and generated the bootstrap, making `plugin_swift_files` always non-empty) unconditionally — so `mix mob.deploy --native` to a physical iPhone broke on an app scaffolded before the plugin system (`invalid option: -Dplugin_swift_files`). The device path now mirrors the sim path: bootstrap + flags only when plugins are activated. Verified `mix mob.deploy --native` to a physical iPhone — full OTP, Phoenix endpoint up, LiveView connected, embedded Livebook home rendered.
+
 ## [0.5.15]
 
 ### Fixed
diff --git a/lib/mob_dev/native_build.ex b/lib/mob_dev/native_build.ex
index b8da3ff..9c8965e 100644
--- a/lib/mob_dev/native_build.ex
+++ b/lib/mob_dev/native_build.ex
@@ -3464,18 +3464,26 @@ defmodule MobDev.NativeBuild do
     # MOB_PLUGIN_SECURITY.md, Layer 2.
     MobDev.Plugin.Validator.raise_on_capability_drift!(activated_plugins)
 
-    # See sim build for the rationale on bundling the bootstrap into
-    # `plugin_swift_files`. Keeping sim + device on the same wiring means
-    # one place to debug "where did mob_register_plugins go?" if/when it
-    # comes up.
-    bootstrap_path = generate_ios_plugin_bootstrap(build_dir)
+    # See sim build for the rationale. Only generate the bootstrap + emit the
+    # -Dplugin_* flags when plugins are activated; an app scaffolded before the
+    # plugin system has no plugin_swift_files/plugin_frameworks option in
+    # ios/build_device.zig, and the bootstrap would otherwise make
+    # plugin_swift_files always non-empty.
+    {plugin_swift_files, plugin_frameworks} =
+      if activated_plugins == [] do
+        {"", ""}
+      else
+        bootstrap_path = generate_ios_plugin_bootstrap(build_dir)
 
-    plugin_swift_files =
-      (MobDev.Plugin.Merge.swift_files(activated_plugins) ++ [bootstrap_path])
-      |> Enum.join(",")
+        swift =
+          (MobDev.Plugin.Merge.swift_files(activated_plugins) ++ [bootstrap_path])
+          |> Enum.join(",")
 
-    plugin_frameworks =
-      activated_plugins |> MobDev.Plugin.Merge.ios_frameworks() |> Enum.join(",")
+        frameworks =
+          activated_plugins |> MobDev.Plugin.Merge.ios_frameworks() |> Enum.join(",")
+
+        {swift, frameworks}
+      end
 
     base_args = [
       "build",
@@ -3493,11 +3501,17 @@ defmodule MobDev.NativeBuild do
       "-Dmodule_name=#{display_name}",
       "-Depmd_build_src=#{epmd_build_src}",
       "-Derrno_compat=#{Path.join(build_dir, "erl_errno_id_compat.c")}",
-      "-Dproject_swift_sources=#{project_swift_sources}",
-      "-Dplugin_swift_files=#{plugin_swift_files}",
-      "-Dplugin_frameworks=#{plugin_frameworks}"
+      "-Dproject_swift_sources=#{project_swift_sources}"
     ]
 
+    plugin_args =
+      for {name, val} <- [
+            {"plugin_swift_files", plugin_swift_files},
+            {"plugin_frameworks", plugin_frameworks}
+          ],
+          val != "",
+          do: "-D#{name}=#{val}"
+
     with {:ok, nif_args} <- project_nif_zig_args(:ios_device) do
       sqlite_args =
         case sqlite_static_lib do
@@ -3507,6 +3521,7 @@ defmodule MobDev.NativeBuild do
 
       args =
         base_args ++
+          plugin_args ++
           nif_args ++
           sqlite_args ++
           mlx_zig_args(mlx_dir) ++
diff --git a/mix.exs b/mix.exs
index e8670a9..c3d6e9f 100644
--- a/mix.exs
+++ b/mix.exs
@@ -4,7 +4,7 @@ defmodule MobDev.MixProject do
   def project do
     [
       app: :mob_dev,
-      version: "0.5.15",
+      version: "0.5.16",
       elixir: "~> 1.19",
       description: "Development tooling for the Mob mobile framework",
       source_url: "https://github.com/genericjam/mob_dev",