feat: from s3 with s3 protocol OK

Author: RaphReynaud

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/GetStream/stream-chat-go/v5 v5.8.1
 	github.com/MakeNowJust/heredoc v1.0.0
 	github.com/aws/aws-sdk-go-v2/config v1.32.7
+	github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.21.0
 	github.com/aws/aws-sdk-go-v2/service/s3 v1.95.1
 	github.com/cheynewallace/tabby v1.1.1
 	github.com/gizak/termui/v3 v3.1.0

go.sum

@@ -58,6 +58,8 @@ github.com/aws/aws-sdk-go-v2/credentials v1.19.7 h1:tHK47VqqtJxOymRrNtUXN5SP/zUT
 github.com/aws/aws-sdk-go-v2/credentials v1.19.7/go.mod h1:qOZk8sPDrxhf+4Wf4oT2urYJrYt3RejHSzgAquYeppw=
 github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.17 h1:I0GyV8wiYrP8XpA70g1HBcQO1JlQxCMTW9npl5UbDHY=
 github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.17/go.mod h1:tyw7BOl5bBe/oqvoIeECFJjMdzXoa/dfVz3QQ5lgHGA=
+github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.21.0 h1:pQZGI0qQXeCHZHMeWzhwPu+4jkWrdrIb2dgpG4OKmco=
+github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.21.0/go.mod h1:XGq5kImVqQT4HUNbbG+0Y8O74URsPNH7CGPg1s1HW5E=
 github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.17 h1:xOLELNKGp2vsiteLsvLPwxC+mYmO6OZ8PYgiuPJzF8U=
 github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.17/go.mod h1:5M5CI3D12dNOtH3/mk6minaRwI2/37ifCURZISxA/IQ=
 github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.17 h1:WWLqlh79iO48yLkj1v3ISRNiv+3KdQoZ6JWyfcsyQik=

pkg/cmd/raw-recording-tool/s3_downloader.go

@@ -14,6 +14,7 @@ import (
 	"strings"
 
 	"github.com/aws/aws-sdk-go-v2/config"
+	s3manager "github.com/aws/aws-sdk-go-v2/feature/s3/manager"
 	"github.com/aws/aws-sdk-go-v2/service/s3"
 )
 
@@ -149,6 +150,40 @@ func parseS3URL(inputURL string) (bucket, key string, err error) {
 	return parts[0], parts[1], nil
 }
 
+// getS3ClientForBucket creates an S3 client configured for the bucket's region
+func (d *S3Downloader) getS3ClientForBucket(ctx context.Context, bucket string) (*s3.Client, error) {
+	// First, load the default config
+	cfg, err := config.LoadDefaultConfig(ctx)
+	if err != nil {
+		return nil, fmt.Errorf("failed to load AWS config: %w", err)
+	}
+
+	// Create a client to detect the bucket region
+	client := s3.NewFromConfig(cfg)
+
+	// Get the actual bucket region
+	region, err := s3manager.GetBucketRegion(ctx, client, bucket)
+	if err != nil {
+		// If we can't detect the region, return the default client
+		if d.verbose {
+			fmt.Printf("Warning: could not detect bucket region, using default: %v\n", err)
+		}
+		return client, nil
+	}
+
+	if d.verbose {
+		fmt.Printf("Detected bucket region: %s\n", region)
+	}
+
+	// Reload config with the correct region
+	cfg, err = config.LoadDefaultConfig(ctx, config.WithRegion(region))
+	if err != nil {
+		return nil, fmt.Errorf("failed to load AWS config with region %s: %w", region, err)
+	}
+
+	return s3.NewFromConfig(cfg), nil
+}
+
 // isCacheValid checks if the cached file is still valid
 func (d *S3Downloader) isCacheValid(ctx context.Context, inputURL, cachedFilePath, metadataPath string) bool {
 	// Check if cached file exists
@@ -193,12 +228,11 @@ func (d *S3Downloader) getS3ETag(ctx context.Context, inputURL string) (string,
 		return "", err
 	}
 
-	cfg, err := config.LoadDefaultConfig(ctx)
+	client, err := d.getS3ClientForBucket(ctx, bucket)
 	if err != nil {
-		return "", fmt.Errorf("failed to load AWS config: %w", err)
+		return "", err
 	}
 
-	client := s3.NewFromConfig(cfg)
 	result, err := client.HeadObject(ctx, &s3.HeadObjectInput{
 		Bucket: &bucket,
 		Key:    &key,
@@ -240,12 +274,11 @@ func (d *S3Downloader) downloadFromS3(ctx context.Context, inputURL, destPath st
 		return "", err
 	}
 
-	cfg, err := config.LoadDefaultConfig(ctx)
+	client, err := d.getS3ClientForBucket(ctx, bucket)
 	if err != nil {
-		return "", fmt.Errorf("failed to load AWS config: %w", err)
+		return "", err
 	}
 
-	client := s3.NewFromConfig(cfg)
 	result, err := client.GetObject(ctx, &s3.GetObjectInput{
 		Bucket: &bucket,
 		Key:    &key,