Skip to content

Commit 28c3d95

Browse files
Uziel Silvathameezb
authored andcommitted
fix(main) Fix linting and undefined cases
Changelog: - Fix linting issues - Define `self.proxy` on the constructor - Prevent issues with undefined variables
1 parent 35ea30b commit 28c3d95

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

google/cloud/sql/connector/connector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@
4040
from google.cloud.sql.connector.lazy import LazyRefreshCache
4141
from google.cloud.sql.connector.monitored_cache import MonitoredCache
4242
import google.cloud.sql.connector.pg8000 as pg8000
43+
from google.cloud.sql.connector.proxy import start_local_proxy
4344
import google.cloud.sql.connector.psycopg as psycopg
4445
import google.cloud.sql.connector.pymysql as pymysql
4546
import google.cloud.sql.connector.pytds as pytds
4647
from google.cloud.sql.connector.resolver import DefaultResolver
4748
from google.cloud.sql.connector.resolver import DnsResolver
4849
from google.cloud.sql.connector.utils import format_database_user
4950
from google.cloud.sql.connector.utils import generate_keys
50-
from google.cloud.sql.connector.proxy import start_local_proxy
5151

5252
logger = logging.getLogger(name=__name__)
5353

@@ -438,7 +438,7 @@ async def connect_async(
438438
# async drivers are unblocking and can be awaited directly
439439
if driver in ASYNC_DRIVERS:
440440
return await connector(
441-
host,
441+
ip_address,
442442
await conn_info.create_ssl_context(enable_iam_auth),
443443
**kwargs,
444444
)

google/cloud/sql/connector/proxy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
limitations under the License.
1515
"""
1616

17-
import socket
18-
import os
19-
import ssl
2017
import asyncio
18+
import os
2119
from pathlib import Path
20+
import socket
21+
import ssl
2222
from typing import Optional
2323

2424
from google.cloud.sql.connector.exceptions import LocalProxyStartupError

google/cloud/sql/connector/psycopg.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import ssl
1818
from typing import Any, TYPE_CHECKING
19-
import threading
2019

2120
SERVER_PROXY_PORT = 3307
2221

tests/unit/test_psycopg.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
import ssl
1919
from typing import Any
2020

21-
from mock import patch, PropertyMock
21+
from mock import patch
22+
from mock import PropertyMock
2223
import pytest
2324

2425
from google.cloud.sql.connector.psycopg import connect

0 commit comments

Comments
 (0)