From e3f5ce14ed0b8e8f36b54b2d08adfd4c3a40d64e Mon Sep 17 00:00:00 2001
From: manthan <manthanut27@gmail.com>
Date: Tue, 20 Oct 2026 01:56:01 +0530
Subject: [PATCH] fix: preserve callflow HTML on staging failure

---
 graphify/callflow_html.py   |  12 ++---
 tests/test_callflow_html.py | 103 ++++++++++++++++++++++++++++++++++++
 2 files changed, 109 insertions(+), 6 deletions(-)

diff --git a/graphify/callflow_html.py b/graphify/callflow_html.py
index 3c8a34b41f..f2d038e06f 100644
--- a/graphify/callflow_html.py
+++ b/graphify/callflow_html.py
@@ -30,7 +30,7 @@
 from datetime import datetime, timezone
 from html import escape
 
-from graphify.paths import GRAPHIFY_OUT, GRAPHIFY_OUT_NAME
+from graphify.paths import GRAPHIFY_OUT, GRAPHIFY_OUT_NAME, write_text_atomic
 
 
 # ──────────────────────────────────────────────
@@ -1991,14 +1991,14 @@ def write_callflow_html(
 </html>""")
 
     # Write output
-    output = "\n".join(html)
+    rendered_html = "\n".join(html)
     output_path.parent.mkdir(parents=True, exist_ok=True)
-    output_path.write_text(output, encoding="utf-8")
+    write_text_atomic(output_path, rendered_html)
 
     # Summary
-    mermaid_count = output.count('<div class="mermaid">')
-    table_count = output.count('<table class="call-table">')
-    section_count = output.count('<h2 id=')
+    mermaid_count = rendered_html.count('<div class="mermaid">')
+    table_count = rendered_html.count('<table class="call-table">')
+    section_count = rendered_html.count('<h2 id=')
 
     if verbose:
         print(f"Call-flow HTML written: {output_path}")
diff --git a/tests/test_callflow_html.py b/tests/test_callflow_html.py
index e42d1b4298..b1005296b1 100644
--- a/tests/test_callflow_html.py
+++ b/tests/test_callflow_html.py
@@ -1,8 +1,11 @@
 import json
+import os
 import subprocess
 import sys
 from pathlib import Path
 
+import pytest
+
 from graphify.callflow_html import derive_sections_from_communities, write_callflow_html
 
 
@@ -345,3 +348,103 @@ def test_call_table_rows_without_whole_graph_params_unchanged(tmp_path):
     # semantics other call sites may rely on).
     export_node = [n for n in nodes if n["id"] == "export"]
     assert "External entry" in generate_call_table_rows(export_node, section_edges, "en")
+
+
+def test_write_callflow_html_preserves_existing_on_staging_write_failure(tmp_path, monkeypatch):
+    """#4562: When staging the new callflow HTML fails during writing to the temporary file,
+    the existing HTML report must remain byte-for-byte unchanged and temporary files cleaned up."""
+    out = _make_graphify_out(tmp_path)
+    report_path = out / "callflow.html"
+    original_bytes = b"<!-- PREVIOUS CALLFLOW HTML -->\n<body>Old Content</body>\n"
+    report_path.write_bytes(original_bytes)
+
+    real_fdopen = os.fdopen
+
+    def faulty_fdopen(fd, *args, **kwargs):
+        raw = real_fdopen(fd, *args, **kwargs)
+
+        class FaultyWriter:
+            def __enter__(self):
+                return self
+
+            def __exit__(self, exc_type, exc_val, exc_tb):
+                raw.close()
+
+            def write(self, data):
+                raise OSError("simulated staging write failure")
+
+        return FaultyWriter()
+
+    monkeypatch.setattr("graphify.paths.os.fdopen", faulty_fdopen)
+
+    with pytest.raises(OSError, match="simulated staging write failure"):
+        write_callflow_html(
+            tmp_path,
+            output="graphify-out/callflow.html",
+            max_sections=4,
+        )
+
+    assert report_path.read_bytes() == original_bytes, "previous report was modified on write failure"
+    assert not any(p.name.startswith(".gfy-") or p.name.endswith(".tmp") for p in out.iterdir()), (
+        f"abandoned temporary file leaked in {out}: {[p.name for p in out.iterdir()]}"
+    )
+
+
+def test_write_callflow_html_preserves_existing_on_staging_close_failure(tmp_path, monkeypatch):
+    """#4562: When staging the new callflow HTML fails during flush/close of the temporary file,
+    the existing HTML report must remain byte-for-byte unchanged and temporary files cleaned up."""
+    out = _make_graphify_out(tmp_path)
+    report_path = out / "callflow.html"
+    original_bytes = b"<!-- PREVIOUS CALLFLOW HTML -->\n<body>Old Content</body>\n"
+    report_path.write_bytes(original_bytes)
+
+    real_fdopen = os.fdopen
+
+    def faulty_close_fdopen(fd, *args, **kwargs):
+        raw = real_fdopen(fd, *args, **kwargs)
+
+        class FaultyCloser:
+            def __enter__(self):
+                return self
+
+            def __exit__(self, exc_type, exc_val, exc_tb):
+                raw.close()
+                raise OSError("simulated staging close failure")
+
+            def write(self, data):
+                return raw.write(data)
+
+        return FaultyCloser()
+
+    monkeypatch.setattr("graphify.paths.os.fdopen", faulty_close_fdopen)
+
+    with pytest.raises(OSError, match="simulated staging close failure"):
+        write_callflow_html(
+            tmp_path,
+            output="graphify-out/callflow.html",
+            max_sections=4,
+        )
+
+    assert report_path.read_bytes() == original_bytes, "previous report was modified on close failure"
+    assert not any(p.name.startswith(".gfy-") or p.name.endswith(".tmp") for p in out.iterdir()), (
+        f"abandoned temporary file leaked in {out}: {[p.name for p in out.iterdir()]}"
+    )
+
+
+def test_write_callflow_html_replaces_existing_report_successfully(tmp_path):
+    """#4562: Replacing an existing callflow HTML report completes atomically and updates content."""
+    out = _make_graphify_out(tmp_path)
+    report_path = out / "callflow.html"
+    report_path.write_text("old version", encoding="utf-8")
+
+    html_path = write_callflow_html(
+        tmp_path,
+        output="graphify-out/callflow.html",
+        max_sections=4,
+    )
+
+    assert html_path == report_path
+    new_content = html_path.read_text(encoding="utf-8")
+    assert "mermaid" in new_content
+    assert "old version" not in new_content
+    assert not any(p.name.startswith(".gfy-") or p.name.endswith(".tmp") for p in out.iterdir())