LegacyOverrides.THREE_POINT_0 includes treatsEscapedQuotesSameWhenNotInQuotes

Author: jmoraleda

src/main/java/com/hubspot/jinjava/LegacyOverrides.java

@@ -21,6 +21,7 @@ public interface LegacyOverrides extends WithLegacyOverrides {
     .withAllowAdjacentTextNodes(true)
     .withUseTrimmingForNotesAndExpressions(true)
     .withKeepNullableLoopValues(true)
+    .withHandleBackslashInQuotesOnly(true)
     .build();
   LegacyOverrides ALL = new Builder()
     .withEvaluateMapKeys(true)

src/test/java/com/hubspot/jinjava/tree/parse/BackslashHandlingTest.java

@@ -27,21 +27,16 @@ private static Jinjava charLegacy() {
     return new Jinjava(
       JinjavaConfig
         .newBuilder()
-        .withLegacyOverrides(LegacyOverrides.newBuilder().build())
+        .withLegacyOverrides(
+          LegacyOverrides.newBuilder().withHandleBackslashInQuotesOnly(false).build()
+        )
         .build()
     );
   }
 
   /** Char-based scanner, Jinja2-compatible backslash behaviour (flag = true). */
   private static Jinjava charNew() {
-    return new Jinjava(
-      JinjavaConfig
-        .newBuilder()
-        .withLegacyOverrides(
-          LegacyOverrides.newBuilder().withHandleBackslashInQuotesOnly(true).build()
-        )
-        .build()
-    );
+    return new Jinjava(JinjavaConfig.newBuilder().build());
   }
 
   /** String-based scanner, legacy backslash behaviour (flag = false). */
@@ -50,7 +45,9 @@ private static Jinjava stringLegacy() {
       JinjavaConfig
         .newBuilder()
         .withTokenScannerSymbols(StringTokenScannerSymbols.builder().build())
-        .withLegacyOverrides(LegacyOverrides.newBuilder().build())
+        .withLegacyOverrides(
+          LegacyOverrides.newBuilder().withHandleBackslashInQuotesOnly(false).build()
+        )
         .build()
     );
   }
@@ -61,9 +58,6 @@ private static Jinjava stringNew() {
       JinjavaConfig
         .newBuilder()
         .withTokenScannerSymbols(StringTokenScannerSymbols.builder().build())
-        .withLegacyOverrides(
-          LegacyOverrides.newBuilder().withHandleBackslashInQuotesOnly(true).build()
-        )
         .build()
     );
   }
@@ -216,10 +210,6 @@ public void stringNew_simpleExpressionUnchanged() {
 
   // ── LegacyOverrides preset assertions ─────────────────────────────────────
   //
-  // handleBackslashInQuotesOnly is an explicit opt-in only. It is NOT included
-  // in THREE_POINT_0 or NONE because existing templates may rely on the legacy
-  // behaviour of \} preventing delimiter recognition. Inclusion in a preset
-  // can be reconsidered in a future major version.
 
   @Test
   public void allPresetDoesNotEnableNewBackslashHandling() {
@@ -228,7 +218,7 @@ public void allPresetDoesNotEnableNewBackslashHandling() {
 
   @Test
   public void threePointZeroPresetDoesNotEnableNewBackslashHandling() {
-    assertThat(LegacyOverrides.THREE_POINT_0.isHandleBackslashInQuotesOnly()).isFalse();
+    assertThat(LegacyOverrides.THREE_POINT_0.isHandleBackslashInQuotesOnly()).isTrue();
   }
 
   @Test

src/test/java/com/hubspot/jinjava/tree/parse/TokenScannerTest.java

@@ -8,6 +8,7 @@
 import com.google.common.io.Resources;
 import com.hubspot.jinjava.BaseJinjavaTest;
 import com.hubspot.jinjava.JinjavaConfig;
+import com.hubspot.jinjava.LegacyOverrides;
 import com.hubspot.jinjava.features.BuiltInFeatures;
 import com.hubspot.jinjava.features.FeatureConfig;
 import com.hubspot.jinjava.features.FeatureStrategies;
@@ -319,6 +320,14 @@ public void testLstripBlocks() {
 
   @Test
   public void itTreatsEscapedQuotesSameWhenNotInQuotes() {
+    config =
+      BaseJinjavaTest
+        .newConfigBuilder()
+        .withLegacyOverrides(
+          LegacyOverrides.newBuilder().withHandleBackslashInQuotesOnly(false).build()
+        )
+        .build();
+
     List<Token> tokens = tokens("tag-with-all-escaped-quotes");
     assertThat(tokens).hasSize(8);
     assertThat(tokens.stream().map(Token::getType).collect(Collectors.toList()))