Rename domain_min/max CLI args to particle_aabb_min/max

Author: w1th0utnam3

splashsurf/src/reconstruction.rs

@@ -83,19 +83,19 @@ pub struct ReconstructSubcommandArgs {
         number_of_values = 3,
         value_names = ["X_MIN", "Y_MIN", "Z_MIN"],
         allow_negative_numbers = true,
-        requires = "domain_max",
+        requires = "particle_aabb_max",
     )]
-    pub domain_min: Option<Vec<f64>>,
+    pub particle_aabb_min: Option<Vec<f64>>,
     /// Upper corner of the domain where surface reconstruction should be performed (requires domain-min to be specified)
     #[arg(
         help_heading = ARGS_BASIC,
         long,
         number_of_values = 3,
         value_names = ["X_MIN", "Y_MIN", "Z_MIN"],
         allow_negative_numbers = true,
-        requires = "domain_min",
+        requires = "particle_aabb_min",
     )]
-    pub domain_max: Option<Vec<f64>>,
+    pub particle_aabb_max: Option<Vec<f64>>,
 
     /// Flag to enable multi-threading to process multiple input files in parallel
     #[arg(
@@ -392,8 +392,8 @@ mod arguments {
 
         fn try_from(args: &ReconstructSubcommandArgs) -> Result<Self, Self::Error> {
             // Convert particle domain args to aabb
-            let domain_aabb = if let (Some(domain_min), Some(domain_max)) =
-                (&args.domain_min, &args.domain_max)
+            let particle_aabb = if let (Some(domain_min), Some(domain_max)) =
+                (&args.particle_aabb_min, &args.particle_aabb_max)
             {
                 Some(try_aabb_from_min_max(
                     domain_min,
@@ -465,7 +465,7 @@ mod arguments {
                 compact_support_radius,
                 cube_size,
                 iso_surface_threshold: args.surface_threshold,
-                particle_aabb: domain_aabb,
+                particle_aabb,
                 enable_multi_threading: args.parallelize_over_particles.into_bool(),
                 spatial_decomposition,
             };

splashsurf/src/tests/cli.rs

@@ -102,20 +102,20 @@ fn test_main_cli() {
         "--particle-radius=0.05",
         "--smoothing-length=3.0",
         "--cube-size=0.75",
-        "--domain-min",
+        "--particle-aabb-min",
         "-1.0",
         "1.0",
         "-1.0",
-        "--domain-max",
+        "--particle-aabb-max",
         "-2.0",
         "2.0",
         "-2.0",
     ])
     .expect("this command is supposed to work")
     .subcommand
     {
-        assert_eq!(rec_args.domain_min, Some(vec![-1.0, 1.0, -1.0]));
-        assert_eq!(rec_args.domain_max, Some(vec![-2.0, 2.0, -2.0]));
+        assert_eq!(rec_args.particle_aabb_min, Some(vec![-1.0, 1.0, -1.0]));
+        assert_eq!(rec_args.particle_aabb_max, Some(vec![-2.0, 2.0, -2.0]));
     };
 
     // Test domain min/max: too many values
@@ -127,12 +127,12 @@ fn test_main_cli() {
             "--particle-radius=0.05",
             "--smoothing-length=3.0",
             "--cube-size=0.75",
-            "--domain-min",
+            "--particle-aabb-min",
             "-1.0",
             "1.0",
             "-1.0",
             "2.0",
-            "--domain-max",
+            "--particle-aabb-max",
             "-2.0",
             "2.0",
             "-2.0",