Merge pull request #624 from reidab/non-string-filter-values

Allow Hash values for filter params

Author: lgebhardt

lib/jsonapi/resource.rb

@@ -638,7 +638,9 @@ def is_filter_relationship?(filter)
 
       def verify_filter(filter, raw, context = nil)
         filter_values = []
-        filter_values += CSV.parse_line(raw) unless raw.nil? || raw.empty?
+        if raw.present?
+          filter_values += raw.is_a?(String) ? CSV.parse_line(raw) : [raw]
+        end
 
         strategy = _allowed_filters.fetch(filter, Hash.new)[:verify]
 

test/controllers/controller_test.rb

@@ -103,6 +103,13 @@ def test_index_filter_by_title
     assert_equal 1, json_response['data'].size
   end
 
+  def test_index_filter_with_hash_values
+    get :index, {filter: {search: {title: 'New post'}}}
+    assert_response :success
+    assert json_response['data'].is_a?(Array)
+    assert_equal 1, json_response['data'].size
+  end
+
   def test_index_filter_by_ids
     get :index, {filter: {ids: '1,2'}}
     assert_response :success

test/fixtures/active_record.rb

@@ -945,6 +945,14 @@ def title=(title)
            records.where('id IN (?)', value)
          }
 
+  filter :search,
+    verify: ->(values, context) {
+      values.all?{|v| v.is_a?(Hash) } && values
+    },
+    apply: -> (records, values, _options) {
+      records.where(title: values.first['title'])
+    }
+
   def self.updatable_fields(context)
     super(context) - [:author, :subject]
   end