Tests validation behavior on :base

Author: lgebhardt

test/controllers/controller_test.rb

@@ -1869,11 +1869,21 @@ def test_update_bad_attributes
     assert_response :bad_request
   end
 
-  def test_delete_with_validation_error
+  def test_delete_with_validation_error_base
     post = Post.create!(title: "can't destroy me", author: Person.first)
     delete :destroy, params: { id: post.id }
 
     assert_equal "can't destroy me", json_response['errors'][0]['title']
+    assert_equal "/data", json_response['errors'][0]['source']['pointer']
+    assert_response :unprocessable_entity
+  end
+
+  def test_delete_with_validation_error_attr
+    post = Post.create!(title: "locked title", author: Person.first)
+    delete :destroy, params: { id: post.id }
+
+    assert_equal "is locked", json_response['errors'][0]['title']
+    assert_equal "/data/attributes/title", json_response['errors'][0]['source']['pointer']
     assert_response :unprocessable_entity
   end
 
@@ -3755,6 +3765,15 @@ def test_caching_with_join_from_resource_with_sql_fragment
     assert_cacheable_get :index, params: {include: 'section'}
     assert_response :success
   end
+
+  def test_delete_with_validation_error_base_on_resource
+    post = Post.create!(title: "can't destroy me either", author: Person.first)
+    delete :destroy, params: { id: post.id }
+
+    assert_equal "can't destroy me", json_response['errors'][0]['title']
+    assert_equal "/data/attributes/base", json_response['errors'][0]['source']['pointer']
+    assert_response :unprocessable_entity
+  end
 end
 
 class Api::V6::SectionsControllerTest < ActionController::TestCase

test/fixtures/active_record.rb

@@ -376,8 +376,19 @@ class Post < ActiveRecord::Base
   before_destroy :destroy_callback
 
   def destroy_callback
-    if title == "can't destroy me"
-      errors.add(:title, "can't destroy me")
+    case title
+    when "can't destroy me", "can't destroy me either"
+      errors.add(:base, "can't destroy me")
+
+      # :nocov:
+      if Rails::VERSION::MAJOR >= 5
+        throw(:abort)
+      else
+        return false
+      end
+      # :nocov:
+    when "locked title"
+      errors.add(:title, "is locked")
 
       # :nocov:
       if Rails::VERSION::MAJOR >= 5
@@ -1775,6 +1786,12 @@ class PostResource < PostResource
       def self.records(options = {})
         _model_class.all.joins('INNER JOIN people on people.id = author_id')
       end
+
+      attribute :base
+
+      def base
+        _model.title
+      end
     end
 
     class CustomerResource < JSONAPI::Resource