Merge pull request #1295 from youngcapital/fix-api-returning-404-when-no-record-found

Return a 404 response when no record is found

Author: lgebhardt

lib/jsonapi/processor.rb

@@ -101,6 +101,7 @@ def show
                                        include_directives,
                                        find_options)
 
+      fail JSONAPI::Exceptions::RecordNotFound.new(id) if resource_set.resource_klasses.empty?
       resource_set.populate!(serializer, context, find_options)
 
       return JSONAPI::ResourceSetOperationResult.new(:ok, resource_set, result_options)

test/integration/requests/request_test.rb

@@ -25,6 +25,11 @@ def test_large_get
     assert_cacheable_jsonapi_get '/api/v2/books?include=book_comments,book_comments.author'
   end
 
+  def test_get_not_found
+    get "/people/2000"
+    assert_jsonapi_response 404
+  end
+
   def test_post_sessions
     session_id = SecureRandom.uuid