Tests sorting on related attributes of has_one relationships

Author: lgebhardt

test/fixtures/active_record.rb

@@ -903,6 +903,9 @@ class IsoCurrenciesController < JSONAPI::ResourceController
   end
 
   module V6
+    class AuthorsController < JSONAPI::ResourceController
+    end
+
     class PostsController < JSONAPI::ResourceController
     end
 
@@ -1753,6 +1756,10 @@ def self.find_records(filters, options = {})
       def fetchable_fields
         super - [:email]
       end
+
+      def self.sortable_fields(context)
+        super(context) + [:"author_detail.author_stuff"]
+      end
     end
 
     class AuthorDetailResource < JSONAPI::Resource
@@ -1772,6 +1779,23 @@ class EmployeeResource < EmployeeResource; end
 
 module Api
   module V6
+    class AuthorDetailResource < JSONAPI::Resource
+      attributes :author_stuff
+    end
+
+    class AuthorResource < JSONAPI::Resource
+      attributes :name, :email
+      model_name 'Person'
+      relationship :posts, to: :many
+      relationship :author_detail, to: :one, foreign_key_on: :related
+
+      filter :name
+
+      def self.sortable_fields(context)
+        super(context) + [:"author_detail.author_stuff"]
+      end
+    end
+
     class PersonResource < PersonResource; end
     class TagResource < TagResource; end
 

test/integration/requests/request_test.rb

@@ -1100,6 +1100,26 @@ def test_sort_parameter_openquoted
     assert_jsonapi_response 400
   end
 
+  def test_sort_primary_attribute
+    get '/api/v6/authors?sort=name', headers: { 'Accept' => JSONAPI::MEDIA_TYPE }
+    assert_jsonapi_response 200
+    assert_equal '1002', json_response['data'][0]['id']
+
+    get '/api/v6/authors?sort=-name', headers: { 'Accept' => JSONAPI::MEDIA_TYPE }
+    assert_jsonapi_response 200
+    assert_equal '1005', json_response['data'][0]['id']
+  end
+
+  def test_sort_included_attribute
+    get '/api/v6/authors?sort=author_detail.author_stuff', headers: { 'Accept' => JSONAPI::MEDIA_TYPE }
+    assert_jsonapi_response 200
+    assert_equal '1000', json_response['data'][0]['id']
+
+    get '/api/v6/authors?sort=-author_detail.author_stuff', headers: { 'Accept' => JSONAPI::MEDIA_TYPE }
+    assert_jsonapi_response 200
+    assert_equal '1002', json_response['data'][0]['id']
+  end
+
   def test_include_parameter_quoted
     get '/api/v2/posts?include=%22author%22', headers: { 'Accept' => JSONAPI::MEDIA_TYPE }
     assert_jsonapi_response 200

test/test_helper.rb

@@ -354,6 +354,7 @@ class CatResource < JSONAPI::Resource
 
     JSONAPI.configuration.route_format = :dasherized_route
     namespace :v6 do
+      jsonapi_resources :authors
       jsonapi_resources :posts
       jsonapi_resources :sections
       jsonapi_resources :customers