test: store ROWS FROM fixtures as structured test data

Author: minleejae

src/test/java/net/sf/jsqlparser/statement/select/RowsFromColumnDefinitionTest.java

@@ -15,12 +15,8 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import java.io.IOException;
-import java.io.InputStream;
-import java.nio.charset.StandardCharsets;
 import java.util.List;
 import java.util.Set;
-import java.util.stream.Stream;
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.expression.Function;
 import net.sf.jsqlparser.expression.LongValue;
@@ -34,30 +30,20 @@
 import net.sf.jsqlparser.util.deparser.StatementDeParser;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.MethodSource;
+import org.junit.jupiter.params.provider.CsvFileSource;
 
 class RowsFromColumnDefinitionTest {
 
-    // Accepted/rejected fixtures were checked against PostgreSQL 18.6.
-    static Stream<String> validSql() throws IOException {
-        return fixture("rows-from-valid.sql");
-    }
-
-    static Stream<String> invalidSql() throws IOException {
-        return fixture("rows-from-invalid.sql");
-    }
-
-    private static Stream<String> fixture(String name) throws IOException {
-        try (InputStream input = RowsFromColumnDefinitionTest.class.getResourceAsStream(name)) {
-            return new String(input.readAllBytes(), StandardCharsets.UTF_8).lines()
-                    .filter(line -> !line.isBlank());
-        }
-    }
-
+    // Accepted/rejected cases are data records, not executable SQL batch scripts.
+    // Both outcomes were checked against PostgreSQL 18.6.
     @ParameterizedTest
-    @MethodSource("validSql")
-    void preservesDefinitionsAndOuterAliasesThroughBothRenderers(String sql)
+    @CsvFileSource(resources = "rows-from-cases.tsv", delimiter = '\t')
+    void preservesValidDefinitionsAndRejectsMalformedLists(boolean valid, String sql)
             throws JSQLParserException {
+        if (!valid) {
+            assertThrows(JSQLParserException.class, () -> parse(sql));
+            return;
+        }
         PlainSelect select = parse(sql);
         StringBuilder visitor = new StringBuilder();
         select.accept(new StatementDeParser(visitor));
@@ -68,12 +54,6 @@ void preservesDefinitionsAndOuterAliasesThroughBothRenderers(String sql)
         }
     }
 
-    @ParameterizedTest
-    @MethodSource("invalidSql")
-    void rejectsTableConstraintsAndMalformedColumnLists(String sql) {
-        assertThrows(JSQLParserException.class, () -> parse(sql));
-    }
-
     @Test
     void eachFunctionOwnsItsDefinitionsIndependentlyOfTheOuterAlias()
             throws JSQLParserException {

src/test/resources/net/sf/jsqlparser/statement/select/rows-from-cases.tsv

@@ -0,0 +1,20 @@
+true	SELECT * FROM ROWS FROM (json_to_recordset('[{"a":1}]') AS (a integer)) WITH ORDINALITY
+true	SELECT * FROM ROWS FROM (json_to_recordset('[{"a":1,"b":"x"}]') AS (a integer, b text)) AS r
+true	SELECT * FROM ROWS FROM (json_to_recordset('[{"a":1}]') AS (a integer), generate_series(1, 2)) WITH ORDINALITY AS r(a, n, ord)
+true	SELECT * FROM ROWS FROM (generate_series(1, 2), jsonb_to_recordset('[{"a":1.25}]'::jsonb) AS (a numeric(10, 2))) AS r(n, amount)
+true	SELECT * FROM ROWS FROM (json_to_record('{"a":"x"}') AS (a text COLLATE "C"))
+true	SELECT * FROM ROWS FROM (json_to_record('{"a":"x"}') AS (a text COLLATE pg_catalog."C"))
+true	SELECT * FROM ROWS FROM (json_to_record('{"a":[1,2]}') AS (a integer[]))
+true	SELECT * FROM ROWS FROM (json_to_record('{"a":"2026-01-01T12:00:00Z"}') AS (a timestamp(6) with time zone))
+true	SELECT * FROM ROWS FROM (json_to_record('{"odd name":1}') AS ("odd name" integer)) AS r("renamed")
+true	SELECT r.* FROM (VALUES ('[{"a":1}]'::json)) AS src(payload) CROSS JOIN LATERAL ROWS FROM (json_to_recordset(src.payload) AS (a integer)) WITH ORDINALITY AS r
+true	SELECT * FROM ROWS FROM (generate_series(1, 2), generate_series(1, 1)) AS r(a, b)
+true	SELECT * FROM ROWS FROM (json_to_record('{"a":1}') AS (a integer), json_to_record('{"b":2}') AS (b integer))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS ())
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS (a))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS (a integer,))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS (a integer NOT NULL))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS (a integer DEFAULT 1))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS r(a integer))
+false	SELECT * FROM ROWS FROM (json_to_record('{}') AS (a integer) WITH ORDINALITY)
+false	SELECT * FROM ROWS FROM ()