Skip to content

Commit 770dbcb

Browse files
authored
unbreak type inference (#157)
1 parent 5935f4a commit 770dbcb

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

test/to_vec.jl

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,9 @@ end
118118

119119
@testset "Tuples" begin
120120
test_to_vec((5, 4))
121-
# TODO remove "< 1.6" once https://github.com/JuliaLang/julia/issues/40277
122-
test_to_vec((5, randn(T, 5)); check_inferred = VERSION v"1.2" && VERSION < v"1.6")
121+
test_to_vec((5, randn(T, 5)); check_inferred = VERSION v"1.2") # broken on Julia 1.6.0, fixed on 1.6.1
123122
test_to_vec((randn(T, 4), randn(T, 4, 3, 2), 1); check_inferred=false)
124-
# TODO remove "< 1.6" once https://github.com/JuliaLang/julia/issues/40277
125-
test_to_vec((5, randn(T, 4, 3, 2), UpperTriangular(randn(T, 4, 4)), 2.5); check_inferred = VERSION v"1.2" && VERSION < v"1.6")
123+
test_to_vec((5, randn(T, 4, 3, 2), UpperTriangular(randn(T, 4, 4)), 2.5); check_inferred = VERSION v"1.2") # broken on Julia 1.6.0, fixed on 1.6.1
126124
test_to_vec(((6, 5), 3, randn(T, 3, 2, 0, 1)); check_inferred=false)
127125
test_to_vec((DummyType(randn(T, 2, 7)), DummyType(randn(T, 3, 9))))
128126
test_to_vec((DummyType(randn(T, 3, 2)), randn(T, 11, 8)))
@@ -168,8 +166,7 @@ end
168166

169167
@testset "Struct" begin
170168
test_to_vec(Composite{ThreeFields}(; a=10.0, b=20.0, c=30.0))
171-
# TODO remove "< 1.6" once https://github.com/JuliaLang/julia/issues/40277
172-
test_to_vec(Composite{ThreeFields}(; a=10.0, b=20.0,), check_inferred = VERSION < v"1.6")
169+
test_to_vec(Composite{ThreeFields}(; a=10.0, b=20.0,)) # broken on Julia 1.6.0, fixed on 1.6.1
173170
test_to_vec(Composite{ThreeFields}(; a=10.0, c=30.0))
174171
test_to_vec(Composite{ThreeFields}(; c=30.0, a=10.0, b=20.0))
175172
end

0 commit comments

Comments
 (0)