From e43d92e9b2253d2762248f652cda1f7a7c5a1df5 Mon Sep 17 00:00:00 2001 From: Cristian Magherusan-Stanciu Date: Mon, 27 Jul 2026 13:51:55 +0200 Subject: [PATCH 1/2] chore(make): add docker skip convenience target to Makefile.terraform A stashed WIP had docker-build/docker-skip/frontend-skip targets wrapping skip_docker_build/skip_docker_push/enable_frontend_build terraform vars. Of those, only the "skip the whole docker build" case still maps to a real variable (enable_docker_build, which replaced skip_docker_build). skip_docker_push and enable_frontend_build no longer exist anywhere in terraform/environments/*/variables.tf, so docker-build (build without push) and frontend-skip have no current equivalent and are documented as such instead of reintroduced. --- Makefile.terraform | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/Makefile.terraform b/Makefile.terraform index e422ccae4..99199fb57 100644 --- a/Makefile.terraform +++ b/Makefile.terraform @@ -3,7 +3,7 @@ .PHONY: help deploy plan destroy profile-list profile-show clean clean-locks \ output aws-dev aws-prod azure-dev gcp-dev quick-plan aws-dev-plan quick-deploy \ - validate fmt state-list state-show frontend-only + validate fmt state-list state-show docker-skip frontend-only # Default profile settings PROVIDER ?= aws @@ -119,6 +119,27 @@ state-list: ## List resources in Terraform state state-show: ## Show detailed state for a resource @cd terraform/environments/$(PROVIDER)/$(PROFILE) && terraform state show $(RESOURCE) +# Docker operations +# +# Note: an earlier draft of this file also had a "docker-build" target +# (build the image but skip the ECR push, via a "skip_docker_push" var) +# and a "frontend-skip" target (skip frontend build, via an +# "enable_frontend_build" var). Neither variable exists anywhere in +# terraform/environments/*/build.tf or variables.tf any more: +# - the build module has no build-without-push option, so "docker-build" +# has no current equivalent; +# - frontend assets are now bundled into the Docker/app build rather than +# built as a separate Terraform-controlled step, and the closest +# surviving flag (enable_cdn) only toggles the CloudFront distribution +# in front of the frontend (defaulting to false already), not whether +# the frontend gets built - so a "frontend-skip" wrapper would be +# redundant with plain `make deploy`. +# Only the "skip the whole Docker build" case still maps to a real +# variable (enable_docker_build, replacing the old skip_docker_build). +docker-skip: ## Deploy without building the Docker image (uses pre-built image_uri) + @echo "⏭️ Deploying without Docker build..." + @./scripts/tf-deploy.sh $(PROVIDER) $(PROFILE) apply -var="enable_docker_build=false" + # Frontend operations frontend-only: ## Deploy frontend only @echo "🎨 Deploying frontend..." From 47994ecf5dc67c109997be6e424b5bd25b869968 Mon Sep 17 00:00:00 2001 From: Cristian Magherusan-Stanciu Date: Mon, 27 Jul 2026 20:13:50 +0200 Subject: [PATCH 2/2] chore(make): list docker-skip in make help Addresses the CodeRabbit finding on Makefile.terraform:139. The help output is hard-coded at lines 13-39 and does not consume the `##` target descriptions, so docker-skip was undiscoverable through `make help` despite carrying one. That matters more than a normal doc gap here: the target exists purely as a convenience wrapper, so a convenience nobody can find is not one. Verified `make -f Makefile.terraform help` now lists it and `make -n -f Makefile.terraform docker-skip` still expands unchanged. --- Makefile.terraform | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.terraform b/Makefile.terraform index 99199fb57..b00196a17 100644 --- a/Makefile.terraform +++ b/Makefile.terraform @@ -27,6 +27,9 @@ help: ## Show this help message @echo " make profile-list # List all available profiles" @echo " make profile-show # Show current profile contents" @echo "" + @echo "Docker Operations:" + @echo " make docker-skip # Deploy without building the Docker image" + @echo "" @echo "Cleanup:" @echo " make destroy # Destroy infrastructure (asks for confirmation)" @echo " make clean # Clean Terraform cache files"