Merge pull request #15 from hugofelp/master

Fixed "Unknown prop" warning among other minor tweaks

Author: zackify

.eslintrc.yml

@@ -0,0 +1,25 @@
+env:
+  browser: true
+  es6: true
+extends: 'eslint:recommended'
+installedESLint: true
+parserOptions:
+  ecmaFeatures:
+    experimentalObjectRestSpread: true
+    jsx: true
+  sourceType: module
+plugins:
+  - react
+rules:
+  indent:
+    - error
+    - 2
+  linebreak-style:
+    - error
+    - unix
+  quotes:
+    - error
+    - single
+  semi:
+    - error
+    - never

package.json

@@ -31,6 +31,8 @@
   "devDependencies": {
     "babel": "^5.8.23",
     "chai": "^3.3.0",
+    "eslint": "3.2.2",
+    "eslint-plugin-react": "6.0.0",
     "gulp": "^3.8.11",
     "legit-tests": "^0.4.4",
     "mocha": "^2.3.3",

src/simple-modal.js

@@ -11,11 +11,11 @@ export default class Modal extends React.Component{
 
     let opacity = 0,
       display = 'block',
-      visibility = 'hidden';
+      visibility = 'hidden'
 
     if(props.show){
-      opacity = 1;
-      display = 'block';
+      opacity = 1
+      display = 'block'
       visibility = 'visible'
     }
 
@@ -24,13 +24,13 @@ export default class Modal extends React.Component{
       display,
       visibility,
       show: props.show
-    };
+    }
 
   }
 
   hideOnOuterClick(event){
     if(this.props.closeOnOuterClick === false) return
-    if(event.target.dataset.modal) this.props.onClose(event)
+    if(event.target.dataset.modal && this.props.onClose instanceof Function) this.props.onClose(event)
   }
 
   componentWillReceiveProps(props){
@@ -78,12 +78,27 @@ export default class Modal extends React.Component{
     if(this.props.transitionSpeed) modalStyle = Object.assign({}, this.state, modalStyle)
 
     return (
-      <div {...this.props} style={modalStyle} onClick={this.hideOnOuterClick} data-modal="true">
+      <div {..._filteredProps(this.props)} style={modalStyle} onClick={this.hideOnOuterClick} data-modal="true">
         <div className={this.props.containerClassName} style={containerStyle}>
           {this.props.children}
         </div>
       </div>
     )
   }
 }
+
+function _filteredProps(props) {
+  const filtered = Object.assign({}, props);
+  [
+    'containerStyle',
+    'containerClassName',
+    'closeOnOuterClick',
+    'show',
+    'onClose'
+  ].map( p => {
+    delete filtered[p]
+  })
+  return filtered
+}
+
 export var closeStyle = styles.close