From 1a36fc8ef3bd19bbda9dec98665e74c51c148b2f Mon Sep 17 00:00:00 2001 From: Matee ullah Malik Date: Sun, 5 Jul 2026 22:13:50 +0000 Subject: [PATCH] ci(release): remove empty ${{ }} expression from bash comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Follow-up to #307. The comment added in that PR contained the literal text '${{ }} interpolation' inside a run: bash block. GitHub Actions validates ${{ ... }} expressions everywhere in the workflow file at dispatch time — including inside bash comments in run: block scalars. An empty ${{ }} expression is a validation error, so every push to master (and every tag push) since #307 landed hits a workflow startup failure: run accepted, 0 jobs scheduled, run_started_at == updated_at, conclusion=failure. Verified failure signature on ea1a9c4 (post-#307 master): run 28756586178 / 28756630521 — status=completed, conclusion=failure, jobs=[], run_started_at == updated_at. Also observed on tag push of v2.6.0-testnet retagged onto ea1a9c4: the release job never scheduled, so assets remained empty. Fix: rephrase the comment to describe the prior pattern in English rather than embedding the literal syntax. No functional change to any step logic. Signed-off-by: Matee ullah Malik --- .github/workflows/build&release.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build&release.yml b/.github/workflows/build&release.yml index 97886754..db2f184f 100644 --- a/.github/workflows/build&release.yml +++ b/.github/workflows/build&release.yml @@ -78,9 +78,10 @@ jobs: # failure (0 jobs, run_attempt=1 completed instantly). Doing the # check inline keeps the raw message inside a bash variable and # only exports the single-line `draft` boolean to downstream steps. - # Prior implementation inlined the message via ${{ }} interpolation, - # which let commit-body tokens (e.g. "deadcode") execute as bash - # and killed v2.6.0-testnet with exit 127. See PR history. + # Prior implementation inlined the message via GitHub Actions + # expression interpolation, which let commit-body tokens (e.g. + # "deadcode") execute as bash and killed v2.6.0-testnet with + # exit 127. See PR history (#303 / #307). if printf '%s' "$TAG_MESSAGE" | grep -qi '\[no-deploy\]'; then echo "draft=true" >> "$GITHUB_OUTPUT" echo "⚠️ [no-deploy] detected — release will be created as DRAFT"