Skip to content

Fix internal spelling typos (HardcodedDellacation, BC_SlIP_WALL, tangental, fite_path_dest, lb) #1498

@sbryngelson

Description

@sbryngelson

Five spelling typos with contained blast radius. Most are cosmetic/grep-readability; fite_path_dest is a clear naming typo.

1. HardcodedDellacationHardcodedDeallocation
Fypp macro defined at src/common/include/ExtrusionHardcodedIC.fpp:195 (#:def HardcodedDellacation()) and invoked 15 times in src/pre_process/m_icpp_patches.fpp (16 total in src/; the correct spelling appears 0 times). Self-consistent so it works, but misspelled. → rename definition + all 15 call sites.

2. BC_SlIP_WALLBC_SLIP_WALL at src/common/m_boundary_common.fpp:263
The correct constant BC_SLIP_WALL is used at lines 100, 130, 167, 197, 233; only line 263 has the lowercase-l typo. Fortran is case-insensitive so it compiles and selects the right constant, but a grep for BC_SLIP_WALL misses this site. → line 263 case (BC_SLIP_WALL).

3. tangentaltangential — 17 occurrences, all in src/simulation/m_collisions.fpp (tangental_vector, tangental_force): lines 82, 93, 131, 132, 133, 137, 138, 143, 149, 165, 170, 207, 208, 209, 211, 212, 216. Cosmetic local-variable rename.

4. fite_path_destfile_path_dest at toolchain/mfc/test/case.py:482

482:    fite_path_dest = folder_path_dest + "lag_bubbles.dat"
487:    shutil.copyfile(file_path_src, fite_path_dest)

Internally consistent (assigned 482, used 487) so it works, but clearly meant to be file_path_dest. Rename for clarity.

5. lblB at src/common/m_finite_differences.fpp:42

24:        integer  :: lB, lE
42:        allocate (fd_coeff_s(-fd_number_in:fd_number_in,lb:lE))

Declared/used everywhere as lB (lines 33, 34, 36, 37, 47, 55) except line 42's lowercase lb. Case-insensitive so it compiles; consistency fix. → lB:lE.


Filed from a repo-wide code-cleanliness review; verified against master @ 40dde5e.

Code references

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions