Wheel building issue for dependency package on Windows platforms

[jmcvey3]

There is an error when building the wheels for aiohttp and bitshuffle on Windows - these are from the NLR-rex package dependence on hsds, and occurs when running pip install mhkit[wave].

Collecting bitshuffle>=0.5.2 (from hsds>=0.8.4->NLR-rex[hsds]>=0.5.0->mhkit[all])
Collecting aiohttp==3.9.4 (from hsds>=0.8.4->NLR-rex[hsds]>=0.5.0->mhkit[all])

Building wheels for collected packages: aiohttp, bitshuffle
  Building wheel for aiohttp (pyproject.toml): started
  Building wheel for aiohttp (pyproject.toml): finished with status 'error'
  Building wheel for bitshuffle (pyproject.toml): started
  Building wheel for bitshuffle (pyproject.toml): finished with status 'error'
Failed to build aiohttp bitshuffle

Pip subprocess error:
  error: subprocess-exited-with-error
  
  × Building wheel for aiohttp (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [106 lines of output]
      *********************
      * Accelerated build *
      *********************
      C:\Users\mcve343\AppData\Local\Temp\pip-build-env-dnyynhe1\overlay\Lib\site-packages\setuptools\dist.py:765: SetuptoolsDeprecationWarning: Licen.
      !!
      
              ********************************************************************************
              Please consider removing the following classifiers in favor of a SPDX license expression:
      
              License :: OSI Approved :: Apache Software License
      
              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
              ********************************************************************************
      
      !!
        self._finalize_license_expression()
      running bdist_wheel
      running build
      running build_py
      creating build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\abc.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\base_protocol.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\client.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\client_exceptions.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\client_proto.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\client_reqrep.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\client_ws.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\compression_utils.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\connector.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\cookiejar.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\formdata.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\hdrs.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\helpers.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\http.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\http_exceptions.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\http_parser.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\http_websocket.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\http_writer.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\locks.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\log.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\multipart.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\payload.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\payload_streamer.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\pytest_plugin.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\resolver.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\streams.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\tcp_helpers.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\test_utils.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\tracing.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\typedefs.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_app.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_exceptions.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_fileresponse.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_log.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_middlewares.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_protocol.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_request.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_response.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_routedef.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_runner.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_server.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_urldispatcher.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\web_ws.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\worker.py -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\__init__.py -> build\lib.win-amd64-cpython-313\aiohttp
      running egg_info
      writing aiohttp.egg-info\PKG-INFO
      writing dependency_links to aiohttp.egg-info\dependency_links.txt
      writing requirements to aiohttp.egg-info\requires.txt
      writing top-level names to aiohttp.egg-info\top_level.txt
      reading manifest file 'aiohttp.egg-info\SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      warning: no files found matching 'aiohttp' anywhere in distribution
      warning: no previously-included files matching '*.pyc' found anywhere in distribution
      warning: no previously-included files matching '*.pyd' found anywhere in distribution
      warning: no previously-included files matching '*.so' found anywhere in distribution
      warning: no previously-included files matching '*.lib' found anywhere in distribution
      warning: no previously-included files matching '*.dll' found anywhere in distribution
      warning: no previously-included files matching '*.a' found anywhere in distribution
      warning: no previously-included files matching '*.obj' found anywhere in distribution
      warning: no previously-included files found matching 'aiohttp\*.html'
      no previously-included directories found matching 'docs\_build'
      adding license file 'LICENSE.txt'
      writing manifest file 'aiohttp.egg-info\SOURCES.txt'
      copying aiohttp\_cparser.pxd -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_find_header.pxd -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_headers.pxi -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_helpers.pyi -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_helpers.pyx -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_http_parser.pyx -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_http_writer.pyx -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\_websocket.pyx -> build\lib.win-amd64-cpython-313\aiohttp
      copying aiohttp\py.typed -> build\lib.win-amd64-cpython-313\aiohttp
      creating build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_cparser.pxd.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_find_header.pxd.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_helpers.pyi.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_helpers.pyx.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_http_parser.pyx.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_http_writer.pyx.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\_websocket.pyx.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      copying aiohttp\.hash\hdrs.py.hash -> build\lib.win-amd64-cpython-313\aiohttp\.hash
      running build_ext
      building 'aiohttp._websocket' extension
      error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-/
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for aiohttp
  error: subprocess-exited-with-error
  
  × Building wheel for bitshuffle (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Can't find hdf5 with pkg-config fallback to static config
      Can't find hdf5 with pkg-config fallback to static config
      Can't find hdf5 with pkg-config fallback to static config
      Can't find hdf5 with pkg-config fallback to static config
      Can't find hdf5 with pkg-config fallback to static config
      running bdist_wheel
      running build
      running build_py
      creating build\lib.win-amd64-cpython-313\bitshuffle
      copying bitshuffle\__init__.py -> build\lib.win-amd64-cpython-313\bitshuffle
      running build_ext
      
      #################################
      # Compiling with OpenMP support #
      #################################
      
      building 'bitshuffle.ext' extension
      error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-/
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for bitshuffle
error: failed-wheel-build-for-install

× Failed to build installable wheels for some pyproject.toml based projects
╰─> aiohttp, bitshuffle

failed

CondaEnvException: Pip failed

[jmcvey3]

@simmsa I'm confused as to why the Windows-based CI tests don't fail on environment setup

[jmcvey3]

Okay, aiohttp==3.94 is only supported on Windows up to python 3.12, but bitshuffle still fails

[simmsa]

@jmcvey3, thanks for reporting!

I think was caused by our team and is due to WPTO hindcast Rex/HSDS dependencies.

I'm also a bit surprised that ci/cd did not catch this.

I'm investigating and am planning to push both a windows ci/cd check and a fix for this.