From 62c505b1063a8d6e26879c91951f6219012c8333 Mon Sep 17 00:00:00 2001 From: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Date: Tue, 18 Aug 2026 23:36:12 +0800 Subject: [PATCH] chore: update eslint rules --- eslint.config.mjs | 1 + .../src/core/clients/nft-api/NftApiClient.test.ts | 1 - .../src/core/clients/price-api/PriceApiClient.test.ts | 1 - .../clients/security-alerts-api/SecurityAlertsApiClient.test.ts | 1 - .../src/core/clients/token-api-client/TokenApiClient.test.ts | 1 - .../src/core/sdk-extensions/transaction-messages.test.ts | 1 - .../src/core/services/assets/AssetsService.test.ts | 1 - .../src/core/services/assets/TokenHelper.test.ts | 1 - .../src/core/services/assets/adapters/SnapAssetsAdapter.test.ts | 1 - .../src/core/services/connection/SolanaConnection.test.ts | 1 - .../core/services/name-resolution/NameResolutionService.test.ts | 1 - .../solana-wallet-snap/src/core/services/nft/NftService.test.ts | 1 - .../src/core/services/send/RecipientClassifier.test.ts | 1 - .../src/core/services/send/SendService.test.ts | 1 - .../src/core/services/send/SendSolBuilder.test.ts | 1 - .../src/core/services/send/SendSplTokenBuilder.test.ts | 1 - .../solana-wallet-snap/src/core/services/signer/Signer.test.ts | 1 - .../solana-wallet-snap/src/core/services/state/State.test.ts | 1 - .../core/services/subscriptions/KeyringAccountMonitor.test.ts | 1 - .../src/core/services/subscriptions/SignatureMonitor.test.ts | 1 - .../src/core/services/subscriptions/SubscriptionService.test.ts | 1 - .../services/subscriptions/WebSocketConnectionService.test.ts | 1 - .../src/core/services/token-prices/TokenPrices.test.ts | 1 - .../src/core/services/transactions/TransactionsService.test.ts | 1 - .../src/core/services/transactions/utils/isSpam.test.ts | 1 - .../src/core/services/wallet/WalletService.test.ts | 1 - .../confirmation/views/ConfirmTransactionRequest/render.test.tsx | 1 - .../src/infrastructure/event-emitter/EventEmitter.test.ts | 1 - 28 files changed, 1 insertion(+), 27 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index d0114ddfa..74fd1d3d0 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -176,6 +176,7 @@ const config = createConfig([ 'jest/no-alias-methods': 'error', 'jest/no-commented-out-tests': 'error', 'jest/no-disabled-tests': 'error', + 'jest/no-mocks-import': 'off', }, settings: { node: { diff --git a/packages/solana-wallet-snap/src/core/clients/nft-api/NftApiClient.test.ts b/packages/solana-wallet-snap/src/core/clients/nft-api/NftApiClient.test.ts index f3f7295de..5d64bdecf 100644 --- a/packages/solana-wallet-snap/src/core/clients/nft-api/NftApiClient.test.ts +++ b/packages/solana-wallet-snap/src/core/clients/nft-api/NftApiClient.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { ICache } from '../../caching/ICache'; import { InMemoryCache } from '../../caching/InMemoryCache'; import type { Serializable } from '../../serialization/types'; diff --git a/packages/solana-wallet-snap/src/core/clients/price-api/PriceApiClient.test.ts b/packages/solana-wallet-snap/src/core/clients/price-api/PriceApiClient.test.ts index 6661ea2dc..316263147 100644 --- a/packages/solana-wallet-snap/src/core/clients/price-api/PriceApiClient.test.ts +++ b/packages/solana-wallet-snap/src/core/clients/price-api/PriceApiClient.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable @typescript-eslint/no-non-null-assertion */ import type { CaipAssetType } from '@metamask/keyring-api'; import { cloneDeep } from 'lodash'; diff --git a/packages/solana-wallet-snap/src/core/clients/security-alerts-api/SecurityAlertsApiClient.test.ts b/packages/solana-wallet-snap/src/core/clients/security-alerts-api/SecurityAlertsApiClient.test.ts index 822a38303..c3fda56e5 100644 --- a/packages/solana-wallet-snap/src/core/clients/security-alerts-api/SecurityAlertsApiClient.test.ts +++ b/packages/solana-wallet-snap/src/core/clients/security-alerts-api/SecurityAlertsApiClient.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { Network } from '../../constants/solana'; import { mockLogger } from '../../services/__mocks__/logger'; import type { ConfigProvider } from '../../services/config'; diff --git a/packages/solana-wallet-snap/src/core/clients/token-api-client/TokenApiClient.test.ts b/packages/solana-wallet-snap/src/core/clients/token-api-client/TokenApiClient.test.ts index 3929c5ae1..f8a426bc7 100644 --- a/packages/solana-wallet-snap/src/core/clients/token-api-client/TokenApiClient.test.ts +++ b/packages/solana-wallet-snap/src/core/clients/token-api-client/TokenApiClient.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { TokenCaipAssetType } from '../../constants/solana'; import { KnownCaip19Id, Network } from '../../constants/solana'; import { mockLogger } from '../../services/__mocks__/logger'; diff --git a/packages/solana-wallet-snap/src/core/sdk-extensions/transaction-messages.test.ts b/packages/solana-wallet-snap/src/core/sdk-extensions/transaction-messages.test.ts index 2bf1eac73..8e30f9139 100644 --- a/packages/solana-wallet-snap/src/core/sdk-extensions/transaction-messages.test.ts +++ b/packages/solana-wallet-snap/src/core/sdk-extensions/transaction-messages.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { Rpc, SimulateTransactionApi } from '@solana/kit'; import { address, diff --git a/packages/solana-wallet-snap/src/core/services/assets/AssetsService.test.ts b/packages/solana-wallet-snap/src/core/services/assets/AssetsService.test.ts index 7ed66f964..7ddfc10c0 100644 --- a/packages/solana-wallet-snap/src/core/services/assets/AssetsService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/assets/AssetsService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { KeyringEvent } from '@metamask/keyring-api'; import { emitSnapKeyringEvent } from '@metamask/keyring-snap-sdk'; import { cloneDeep } from 'lodash'; diff --git a/packages/solana-wallet-snap/src/core/services/assets/TokenHelper.test.ts b/packages/solana-wallet-snap/src/core/services/assets/TokenHelper.test.ts index 4d0898391..31c6a163b 100644 --- a/packages/solana-wallet-snap/src/core/services/assets/TokenHelper.test.ts +++ b/packages/solana-wallet-snap/src/core/services/assets/TokenHelper.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { Mint } from '@solana-program/token-2022'; import type { Account, Address } from '@solana/kit'; import { lamports } from '@solana/kit'; diff --git a/packages/solana-wallet-snap/src/core/services/assets/adapters/SnapAssetsAdapter.test.ts b/packages/solana-wallet-snap/src/core/services/assets/adapters/SnapAssetsAdapter.test.ts index 7c971bd4e..3d46e21c1 100644 --- a/packages/solana-wallet-snap/src/core/services/assets/adapters/SnapAssetsAdapter.test.ts +++ b/packages/solana-wallet-snap/src/core/services/assets/adapters/SnapAssetsAdapter.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { cloneDeep } from 'lodash'; import type { ICache } from '../../../caching/ICache'; diff --git a/packages/solana-wallet-snap/src/core/services/connection/SolanaConnection.test.ts b/packages/solana-wallet-snap/src/core/services/connection/SolanaConnection.test.ts index 580196c2d..257b539c7 100644 --- a/packages/solana-wallet-snap/src/core/services/connection/SolanaConnection.test.ts +++ b/packages/solana-wallet-snap/src/core/services/connection/SolanaConnection.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable @typescript-eslint/no-require-imports */ import { fetchJsonParsedAccount } from '@solana/kit'; diff --git a/packages/solana-wallet-snap/src/core/services/name-resolution/NameResolutionService.test.ts b/packages/solana-wallet-snap/src/core/services/name-resolution/NameResolutionService.test.ts index 7392c2267..869dd3f90 100644 --- a/packages/solana-wallet-snap/src/core/services/name-resolution/NameResolutionService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/name-resolution/NameResolutionService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { expect } from '@jest/globals'; import { resolveDomain, diff --git a/packages/solana-wallet-snap/src/core/services/nft/NftService.test.ts b/packages/solana-wallet-snap/src/core/services/nft/NftService.test.ts index 083bb923f..afc7396aa 100644 --- a/packages/solana-wallet-snap/src/core/services/nft/NftService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/nft/NftService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { mockLogger } from '../__mocks__/logger'; import type { SolanaConnection } from '../connection'; import { NftService } from './NftService'; diff --git a/packages/solana-wallet-snap/src/core/services/send/RecipientClassifier.test.ts b/packages/solana-wallet-snap/src/core/services/send/RecipientClassifier.test.ts index d035a8a00..42412e3a2 100644 --- a/packages/solana-wallet-snap/src/core/services/send/RecipientClassifier.test.ts +++ b/packages/solana-wallet-snap/src/core/services/send/RecipientClassifier.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { SYSTEM_PROGRAM_ADDRESS } from '@solana-program/system'; import { TOKEN_PROGRAM_ADDRESS } from '@solana-program/token'; import { TOKEN_2022_PROGRAM_ADDRESS } from '@solana-program/token-2022'; diff --git a/packages/solana-wallet-snap/src/core/services/send/SendService.test.ts b/packages/solana-wallet-snap/src/core/services/send/SendService.test.ts index 30df99431..52e2a49f9 100644 --- a/packages/solana-wallet-snap/src/core/services/send/SendService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/send/SendService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { SolMethod } from '@metamask/keyring-api'; import { lamports } from '@solana/kit'; diff --git a/packages/solana-wallet-snap/src/core/services/send/SendSolBuilder.test.ts b/packages/solana-wallet-snap/src/core/services/send/SendSolBuilder.test.ts index b61b0af43..5df1c1a65 100644 --- a/packages/solana-wallet-snap/src/core/services/send/SendSolBuilder.test.ts +++ b/packages/solana-wallet-snap/src/core/services/send/SendSolBuilder.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { address } from '@solana/kit'; import BigNumber from 'bignumber.js'; diff --git a/packages/solana-wallet-snap/src/core/services/send/SendSplTokenBuilder.test.ts b/packages/solana-wallet-snap/src/core/services/send/SendSplTokenBuilder.test.ts index 7dff1e102..786fa4912 100644 --- a/packages/solana-wallet-snap/src/core/services/send/SendSplTokenBuilder.test.ts +++ b/packages/solana-wallet-snap/src/core/services/send/SendSplTokenBuilder.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { Mint } from '@solana-program/token-2022'; /* eslint-disable @typescript-eslint/no-require-imports */ import { address, lamports } from '@solana/kit'; diff --git a/packages/solana-wallet-snap/src/core/services/signer/Signer.test.ts b/packages/solana-wallet-snap/src/core/services/signer/Signer.test.ts index 59d3f74f5..e5243e623 100644 --- a/packages/solana-wallet-snap/src/core/services/signer/Signer.test.ts +++ b/packages/solana-wallet-snap/src/core/services/signer/Signer.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { getSignatureFromTransaction, isTransactionMessageWithBlockhashLifetime, diff --git a/packages/solana-wallet-snap/src/core/services/state/State.test.ts b/packages/solana-wallet-snap/src/core/services/state/State.test.ts index 44c701aba..4c675b348 100644 --- a/packages/solana-wallet-snap/src/core/services/state/State.test.ts +++ b/packages/solana-wallet-snap/src/core/services/state/State.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable jest/prefer-strict-equal */ import BigNumber from 'bignumber.js'; diff --git a/packages/solana-wallet-snap/src/core/services/subscriptions/KeyringAccountMonitor.test.ts b/packages/solana-wallet-snap/src/core/services/subscriptions/KeyringAccountMonitor.test.ts index 3aff64bff..8ae4a7e88 100644 --- a/packages/solana-wallet-snap/src/core/services/subscriptions/KeyringAccountMonitor.test.ts +++ b/packages/solana-wallet-snap/src/core/services/subscriptions/KeyringAccountMonitor.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable @typescript-eslint/no-non-null-assertion */ import { TransactionType } from '@metamask/keyring-api'; diff --git a/packages/solana-wallet-snap/src/core/services/subscriptions/SignatureMonitor.test.ts b/packages/solana-wallet-snap/src/core/services/subscriptions/SignatureMonitor.test.ts index 1a2d82335..6ce10b5a6 100644 --- a/packages/solana-wallet-snap/src/core/services/subscriptions/SignatureMonitor.test.ts +++ b/packages/solana-wallet-snap/src/core/services/subscriptions/SignatureMonitor.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable @typescript-eslint/no-non-null-assertion */ import type { Transaction } from '@metamask/keyring-api'; diff --git a/packages/solana-wallet-snap/src/core/services/subscriptions/SubscriptionService.test.ts b/packages/solana-wallet-snap/src/core/services/subscriptions/SubscriptionService.test.ts index 724c946ff..f7bed5297 100644 --- a/packages/solana-wallet-snap/src/core/services/subscriptions/SubscriptionService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/subscriptions/SubscriptionService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { WebSocketMessage } from '@metamask/snaps-sdk'; import { Duration } from '@metamask/utils'; diff --git a/packages/solana-wallet-snap/src/core/services/subscriptions/WebSocketConnectionService.test.ts b/packages/solana-wallet-snap/src/core/services/subscriptions/WebSocketConnectionService.test.ts index b95025dc1..80e1a4c3b 100644 --- a/packages/solana-wallet-snap/src/core/services/subscriptions/WebSocketConnectionService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/subscriptions/WebSocketConnectionService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { WebSocketConnection } from '../../../entities'; import { EventEmitter } from '../../../infrastructure'; import { Network } from '../../constants/solana'; diff --git a/packages/solana-wallet-snap/src/core/services/token-prices/TokenPrices.test.ts b/packages/solana-wallet-snap/src/core/services/token-prices/TokenPrices.test.ts index 3b7b39dc3..2ae91e22d 100644 --- a/packages/solana-wallet-snap/src/core/services/token-prices/TokenPrices.test.ts +++ b/packages/solana-wallet-snap/src/core/services/token-prices/TokenPrices.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { Duration } from '@metamask/utils'; import { MOCK_HISTORICAL_PRICES } from '../../clients/price-api/mocks/historical-prices'; diff --git a/packages/solana-wallet-snap/src/core/services/transactions/TransactionsService.test.ts b/packages/solana-wallet-snap/src/core/services/transactions/TransactionsService.test.ts index 924b750d4..6f9ea34ce 100644 --- a/packages/solana-wallet-snap/src/core/services/transactions/TransactionsService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/transactions/TransactionsService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ /* eslint-disable @typescript-eslint/no-non-null-assertion */ import type { Transaction } from '@metamask/keyring-api'; import { address as asAddress } from '@solana/kit'; diff --git a/packages/solana-wallet-snap/src/core/services/transactions/utils/isSpam.test.ts b/packages/solana-wallet-snap/src/core/services/transactions/utils/isSpam.test.ts index 7b2af53af..3c4df6586 100644 --- a/packages/solana-wallet-snap/src/core/services/transactions/utils/isSpam.test.ts +++ b/packages/solana-wallet-snap/src/core/services/transactions/utils/isSpam.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { address as asAddress } from '@solana/kit'; import { Network } from '../../../constants/solana'; diff --git a/packages/solana-wallet-snap/src/core/services/wallet/WalletService.test.ts b/packages/solana-wallet-snap/src/core/services/wallet/WalletService.test.ts index 438d55bb2..65e39a59b 100644 --- a/packages/solana-wallet-snap/src/core/services/wallet/WalletService.test.ts +++ b/packages/solana-wallet-snap/src/core/services/wallet/WalletService.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { SolMethod } from '@metamask/keyring-api'; import { Network } from '../../constants/solana'; diff --git a/packages/solana-wallet-snap/src/features/confirmation/views/ConfirmTransactionRequest/render.test.tsx b/packages/solana-wallet-snap/src/features/confirmation/views/ConfirmTransactionRequest/render.test.tsx index 80b7b5118..f5ac3de05 100644 --- a/packages/solana-wallet-snap/src/features/confirmation/views/ConfirmTransactionRequest/render.test.tsx +++ b/packages/solana-wallet-snap/src/features/confirmation/views/ConfirmTransactionRequest/render.test.tsx @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import type { KeyringRequest } from '@metamask/keyring-api'; import { KeyringRpcMethod, SolMethod } from '@metamask/keyring-api'; import { installSnap } from '@metamask/snaps-jest'; diff --git a/packages/solana-wallet-snap/src/infrastructure/event-emitter/EventEmitter.test.ts b/packages/solana-wallet-snap/src/infrastructure/event-emitter/EventEmitter.test.ts index f9436bd3e..364090deb 100644 --- a/packages/solana-wallet-snap/src/infrastructure/event-emitter/EventEmitter.test.ts +++ b/packages/solana-wallet-snap/src/infrastructure/event-emitter/EventEmitter.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable jest/no-mocks-import -- Test fixtures are imported directly. */ import { mockLogger } from '../../core/services/__mocks__/logger'; import { EventEmitter } from './EventEmitter';