From fbff0dda6ca2513e992047c3fe6a3f05294ccbeb Mon Sep 17 00:00:00 2001 From: Ecys <73040912+Eccys@users.noreply.github.com> Date: Sat, 24 Oct 2026 06:07:32 +0000 Subject: [PATCH] fix(render): omit DepthStencilState on depthless pipelines for Vulkan compatibility --- .../renderer/MeteorRenderPipelines.java | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/main/java/meteordevelopment/meteorclient/renderer/MeteorRenderPipelines.java b/src/main/java/meteordevelopment/meteorclient/renderer/MeteorRenderPipelines.java index a80f367ba7d..bb1e054c5c7 100644 --- a/src/main/java/meteordevelopment/meteorclient/renderer/MeteorRenderPipelines.java +++ b/src/main/java/meteordevelopment/meteorclient/renderer/MeteorRenderPipelines.java @@ -47,7 +47,6 @@ public abstract class MeteorRenderPipelines { .withVertexBinding(0, DefaultVertexFormat.POSITION_COLOR).withPrimitiveTopology(PrimitiveTopology.TRIANGLES) .withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh")) .withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh")) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() @@ -59,7 +58,6 @@ public abstract class MeteorRenderPipelines { .withVertexBinding(0, DefaultVertexFormat.POSITION_COLOR).withPrimitiveTopology(PrimitiveTopology.DEBUG_LINES) .withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh")) .withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh")) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() @@ -96,7 +94,6 @@ public abstract class MeteorRenderPipelines { .withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh")) .withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh")) .withShaderDefine("UI") - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(true) .build() @@ -108,7 +105,6 @@ public abstract class MeteorRenderPipelines { .withVertexShader(MeteorClient.identifier("shaders/pos_color.vsh")) .withFragmentShader(MeteorClient.identifier("shaders/pos_color.fsh")) .withShaderDefine("UI") - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(true) .build() @@ -122,7 +118,6 @@ public abstract class MeteorRenderPipelines { .withBindGroupLayout(BindGroupLayout.builder() .withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(true) .build() @@ -136,7 +131,6 @@ public abstract class MeteorRenderPipelines { .withBindGroupLayout(BindGroupLayout.builder() .withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(true) .build() @@ -154,7 +148,6 @@ public abstract class MeteorRenderPipelines { .withUniform("PostData", UniformType.UNIFORM_BUFFER) .withUniform("OutlineData", UniformType.UNIFORM_BUFFER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() @@ -171,7 +164,6 @@ public abstract class MeteorRenderPipelines { .withUniform("PostData", UniformType.UNIFORM_BUFFER) .withUniform("ImageData", UniformType.UNIFORM_BUFFER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() @@ -188,7 +180,6 @@ public abstract class MeteorRenderPipelines { .withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER) .withUniform("BlurData", UniformType.UNIFORM_BUFFER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() @@ -203,19 +194,17 @@ public abstract class MeteorRenderPipelines { .withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER) .withUniform("BlurData", UniformType.UNIFORM_BUFFER) .build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build() ); public static final RenderPipeline BLUR_PASSTHROUGH = add(new ExtendedRenderPipelineBuilder(MESH_UNIFORMS) - .withLocation(MeteorClient.identifier("pipeline/blur/up")) + .withLocation(MeteorClient.identifier("pipeline/blur/passthrough")) .withVertexBinding(0, MeteorVertexFormats.POS2).withPrimitiveTopology(PrimitiveTopology.TRIANGLES) .withVertexShader(MeteorClient.identifier("shaders/passthrough.vsh")) .withFragmentShader(MeteorClient.identifier("shaders/passthrough.fsh")) .withBindGroupLayout(BindGroupLayout.builder().withUniform("u_Texture", UniformType.COMBINED_IMAGE_SAMPLER).build()) - .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) .withColorTargetState(new ColorTargetState(BlendFunction.TRANSLUCENT)) .withCull(false) .build()