refactor(governance-runtime): use decision category helpers

Author: rian-be

src/Governance/Runtime/Approval/Execution/MutationRequestApprovalDecisionExecutor.cs

@@ -106,8 +106,8 @@ private static List<MutationRequestDecision> BuildDecisionHistory(
                 string.Equals(requirement.ApprovalGroupId, resolvedRequirement.ApprovalGroupId, StringComparison.Ordinal) &&
                 requirement.Status == MutationApprovalRequirementStatus.Satisfied))
         {
-            decisions.Add(MutationRequestDecision.Create(
-                MutationRequestDecisionType.Approval(MutationRequestApprovalDecisionType.QuorumSatisfied),
+            decisions.Add(MutationRequestDecision.Approval(
+                MutationRequestApprovalDecisionType.QuorumSatisfied,
                 decisionContext,
                 reason: $"Approval quorum satisfied for group '{resolvedRequirement.ApprovalGroupId}'.",
                 metadata: new Dictionary<string, object>
@@ -122,15 +122,15 @@ private static List<MutationRequestDecision> BuildDecisionHistory(
 
         if (finalizeApprovedRequest && isFullyApproved)
         {
-            decisions.Add(MutationRequestDecision.Create(
-                MutationRequestDecisionType.Lifecycle(MutationRequestLifecycleDecisionType.Approved),
+            decisions.Add(MutationRequestDecision.Lifecycle(
+                MutationRequestLifecycleDecisionType.Approved,
                 decisionContext,
                 reason: "All approval requirements were fulfilled."));
         }
         else if (!finalizeApprovedRequest)
         {
-            decisions.Add(MutationRequestDecision.Create(
-                MutationRequestDecisionType.Lifecycle(MutationRequestLifecycleDecisionType.Rejected),
+            decisions.Add(MutationRequestDecision.Lifecycle(
+                MutationRequestLifecycleDecisionType.Rejected,
                 decisionContext,
                 reason: reason ?? rejection?.Message ?? decisionContext.Reason ?? "Request was rejected during approval workflow."));
         }

src/Governance/Runtime/Approval/Execution/MutationRequestApprovalExpirationExecutor.cs

@@ -60,8 +60,8 @@ requirement.ExpiresAt is not null &&
                         ? "Approval requirement expired."
                         : $"Approval requirement expired at '{requirement.ExpiresAt:O}'.")));
 
-            decisions.Add(MutationRequestDecision.Create(
-                MutationRequestDecisionType.Lifecycle(MutationRequestLifecycleDecisionType.Rejected),
+            decisions.Add(MutationRequestDecision.Lifecycle(
+                MutationRequestLifecycleDecisionType.Rejected,
                 decisionContext,
                 reason: "Request was rejected because one or more approval requirements expired."));
 

src/Governance/Runtime/Execution/Outcome/GovernedExecutionDecisionFactory.cs

@@ -14,8 +14,8 @@ public static MutationRequestDecision CreateRejectedDecision(
         string reason,
         IReadOnlyDictionary<string, object> metadata)
     {
-        return MutationRequestDecision.Create(
-            MutationRequestDecisionType.Lifecycle(MutationRequestLifecycleDecisionType.Rejected),
+        return MutationRequestDecision.Lifecycle(
+            MutationRequestLifecycleDecisionType.Rejected,
             governanceContext,
             reason,
             metadata);
@@ -26,8 +26,8 @@ public static MutationRequestDecision CreateExecutedDecision<TState>(
         string resultingStateVersion,
         MutationResult<TState> mutationResult)
     {
-        return MutationRequestDecision.Create(
-            MutationRequestDecisionType.Lifecycle(MutationRequestLifecycleDecisionType.Executed),
+        return MutationRequestDecision.Lifecycle(
+            MutationRequestLifecycleDecisionType.Executed,
             governanceContext,
             "Governed request executed successfully.",
             new Dictionary<string, object>

src/Governance/Runtime/Resolution/Execution/MutationRequestVersionResolutionFactory.cs

@@ -20,8 +20,8 @@ public static MutationRequestVersionResolution BuildValidated(
         MutationRequestVersionEvaluation evaluation,
         MutationContext resolutionContext)
     {
-        var validatedDecision = MutationRequestDecision.Create(
-            MutationRequestDecisionType.VersionResolution(MutationRequestVersionResolutionDecisionType.Validated),
+        var validatedDecision = MutationRequestDecision.VersionResolution(
+            MutationRequestVersionResolutionDecisionType.Validated,
             resolutionContext,
             reason: MutationRequestVersionResolutionState.BuildValidatedReason(
                 evaluation.ExpectedStateVersion,
@@ -48,8 +48,8 @@ public static MutationRequestVersionResolution BuildRejectedAsStale(
         MutationRequestVersionEvaluation evaluation,
         MutationContext resolutionContext)
     {
-        var decision = MutationRequestDecision.Create(
-            MutationRequestDecisionType.VersionResolution(MutationRequestVersionResolutionDecisionType.RejectedAsStale),
+        var decision = MutationRequestDecision.VersionResolution(
+            MutationRequestVersionResolutionDecisionType.RejectedAsStale,
             resolutionContext,
             reason: MutationRequestVersionResolutionState.BuildStaleReason(
                 evaluation.ExpectedStateVersion!,
@@ -81,8 +81,8 @@ public static MutationRequestVersionResolution BuildRenewedApprovalRequired(
         MutationRequestVersionEvaluation evaluation,
         MutationContext resolutionContext)
     {
-        var decision = MutationRequestDecision.Create(
-            MutationRequestDecisionType.VersionResolution(MutationRequestVersionResolutionDecisionType.RenewedApprovalRequired),
+        var decision = MutationRequestDecision.VersionResolution(
+            MutationRequestVersionResolutionDecisionType.RenewedApprovalRequired,
             resolutionContext,
             reason: MutationRequestVersionResolutionState.BuildStaleReason(
                 evaluation.ExpectedStateVersion!,
@@ -114,8 +114,8 @@ public static MutationRequestVersionResolution BuildRevalidationRequired(
         MutationRequestVersionEvaluation evaluation,
         MutationContext resolutionContext)
     {
-        var decision = MutationRequestDecision.Create(
-            MutationRequestDecisionType.VersionResolution(MutationRequestVersionResolutionDecisionType.RevalidationRequired),
+        var decision = MutationRequestDecision.VersionResolution(
+            MutationRequestVersionResolutionDecisionType.RevalidationRequired,
             resolutionContext,
             reason: MutationRequestVersionResolutionState.BuildStaleReason(
                 evaluation.ExpectedStateVersion!,