esp32dev_compat build fails since #331

[softhack007]

What happened?

both local and github action builds fail for esp32dev_compat

example job log: https://github.com/MoonModules/WLED-MM/actions/runs/27957475174/job/82729657967

To Reproduce Bug

build esp32dev_compat

Expected Behavior

build succeeds, firmware runs,

Install Method

Self-Compiled or other

What version/release of MM WLED?

latest mdev (14.7.3-mdev)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

Run pio run -e esp32dev_compat
Processing esp32dev_compat (board: esp32dev; platform: espressif32@3.5.0; framework: arduino)
--------------------------------------------------------------------------------

[...] 

✓ Patched wled-audioreactive library.json to exclude .cpp from compilation
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/esp32dev.html
PLATFORM: Espressif 32 (3.5.0) > Espressif ESP32 Dev Module
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
DEBUG: Current (esp-prog) External (esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES: 
 - framework-arduinoespressif32 @ 0.0.0+sha.4b0c087 
 - tool-esptoolpy @ 1.30100.210531 (3.1.0) 
 - toolchain-xtensa32 @ 2.50200.97 (5.2.0)
Converting wled00.ino
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ strict
Library Manager: Installing IRremoteESP8266 @ 2.8.2
Unpacking 0% 10% 20% 30% 40% 50% 60% 70% 80% 90% 100%
Library Manager: IRremoteESP8266@2.8.2 has been installed!
Found 40 compatible libraries
Scanning dependencies...
Dependency Graph
|-- AsyncTCP @ 3.4.7
|-- LittleFS_esp32 @ 1.0.6+sha.820c01e
|-- NeoPixelBus @ 2.7.5
|-- FastLED_no_fastled @ 3.7.1+sha.9ff26b9
|-- IRremoteESP8266 @ 2.8.2
|-- ESPAsyncWebServerWLED @ 2.4.2+sha.39b830c
|-- AnimatedGIF @ 1.4.7
|-- GifDecoder @ 1.1.0+sha.bc3af18
|-- wled-audioreactive @ 0.0.0+sha.171c0bb
|-- arduinoFFT @ 1.9.2+sha.56c867c
|-- Wire @ 1.0.1
|-- SD(esp32) @ 1.0.5
|-- SD_MMC @ 1.0
|-- SPI @ 1.0
|-- EEPROM @ 1.0.3
|-- ArduinoOTA @ 1.0
|-- DNSServer @ 1.1.0
|-- ESPmDNS @ 1.0
|-- WiFi @ 1.0
|-- Update @ 1.0
|-- ESP32 Async UDP @ 1.0.0
|-- WebServer @ 1.0
Building in release mode
Compiling .pio/build/esp32dev_compat/lib98a/FastLED_no_fastled/FastLED.cpp.o
Compiling .pio/build/esp32dev_compat/lib98a/FastLED_no_fastled/bitswap.cpp.o

[...]

Archiving .pio/build/esp32dev_compat/libFrameworkArduino.a
Indexing .pio/build/esp32dev_compat/libFrameworkArduino.a
Linking .pio/build/esp32dev_compat/firmware.elf
/home/runner/.platformio/packages/toolchain-xtensa32/bin/../lib/gcc/xtensa-esp32-elf/5.2.0/../../../../xtensa-esp32-elf/bin/ld:.pio/build/esp32dev_compat/lib98a/FastLED_no_fastled/FastLED.cpp.o: file format not recognized; treating as linker script
/home/runner/.platformio/packages/toolchain-xtensa32/bin/../lib/gcc/xtensa-esp32-elf/5.2.0/../../../../xtensa-esp32-elf/bin/ld:.pio/build/esp32dev_compat/lib98a/FastLED_no_fastled/FastLED.cpp.o:1: syntax error
collect2: error: ld returned 1 exit status
*** [.pio/build/esp32dev_compat/firmware.elf] Error 1

Anything else?

other build pass - the main difference is that other esp32 build are using the newer arduino-esp32 v2.0.x framework.

Code of Conduct

• I agree to follow this project's Code of Conduct

[softhack007]

files from my local build

1. esp32dev_compat: compile_commands.json, FastLED_no_fastled.zip
2. esp32_4MB_V4_M: compile_commands.json, FastLED_no_fastled.zip

[softhack007]

@coderabbitai please compare relevant files from the two builds in #371 (comment). Analyze the changes in #331, and try to identify the root cause of the failed build.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Issue `#371` details ==="
gh issue view 371 --repo MoonModules/WLED-MM --json title,body,comments | jq -r '.title, .body'

echo ""
echo "=== Issue `#371` comments ==="
gh issue view 371 --repo MoonModules/WLED-MM --json comments | jq -r '.comments[] | "--- COMMENT by \(.author.login) ---\n\(.body)\n"'

Length of output: 4718

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== PR `#331` details ==="
gh pr view 331 --repo MoonModules/WLED-MM --json title,body,files | jq -r '.title, .body'

echo ""
echo "=== PR `#331` changed files ==="
gh pr view 331 --repo MoonModules/WLED-MM --json files | jq -r '.files[] | "\(.path) (+\(.additions) -\(.deletions))"'

Length of output: 1409

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Downloading esp32dev_compat FastLED_no_fastled.zip ==="
curl -sL -o /tmp/build1_fastled.zip "https://github.com/user-attachments/files/29209735/FastLED_no_fastled.zip"
echo "Download status: $?"
ls -la /tmp/build1_fastled.zip 2>/dev/null && echo "Downloaded successfully"

echo ""
echo "=== Downloading esp32_4MB_V4_M FastLED_no_fastled.zip ==="
curl -sL -o /tmp/build2_fastled.zip "https://github.com/user-attachments/files/29209992/FastLED_no_fastled.zip"
echo "Download status: $?"
ls -la /tmp/build2_fastled.zip 2>/dev/null && echo "Downloaded successfully"

echo ""
echo "=== Extracting build1 (esp32dev_compat) ==="
mkdir -p /tmp/build1
unzip -q /tmp/build1_fastled.zip -d /tmp/build1/ 2>/dev/null || echo "Extraction failed or zip not valid"
ls /tmp/build1/ 2>/dev/null

echo ""
echo "=== Extracting build2 (esp32_4MB_V4_M) ==="
mkdir -p /tmp/build2
unzip -q /tmp/build2_fastled.zip -d /tmp/build2/ 2>/dev/null || echo "Extraction failed or zip not valid"
ls /tmp/build2/ 2>/dev/null

Length of output: 1556

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Downloading esp32dev_compat compile_commands.json ==="
curl -sL -o /tmp/build1_compile_commands.json "https://github.com/user-attachments/files/29209742/compile_commands.json"
echo "Size: $(wc -c < /tmp/build1_compile_commands.json) bytes"

echo ""
echo "=== Downloading esp32_4MB_V4_M compile_commands.json ==="
curl -sL -o /tmp/build2_compile_commands.json "https://github.com/user-attachments/files/29209968/compile_commands.json"
echo "Size: $(wc -c < /tmp/build2_compile_commands.json) bytes"

echo ""
echo "=== Checking if files are valid JSON ==="
python3 -c "
import json

with open('/tmp/build1_compile_commands.json') as f:
    b1 = json.load(f)
print(f'Build1 entries: {len(b1)}')

with open('/tmp/build2_compile_commands.json') as f:
    b2 = json.load(f)
print(f'Build2 entries: {len(b2)}')
"

Length of output: 1129

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Contents of build1 (esp32dev_compat) FastLED dir ==="
find /tmp/build1 -type f | sort
echo ""
echo "=== Sizes ==="
find /tmp/build1 -type f -exec ls -la {} \;

echo ""
echo "=== Contents of build2 (esp32_4MB_V4_M) FastLED dir ==="
find /tmp/build2 -type f | sort
echo ""
echo "=== Sizes ==="
find /tmp/build2 -type f -exec ls -la {} \;

Length of output: 4121

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Check file type of FastLED.cpp.o in build1 (esp32dev_compat) ==="
file /tmp/build1/FastLED_no_fastled/FastLED.cpp.o 2>/dev/null || echo "File not found"

echo ""
echo "=== Check file type of FastLED.cpp.o in build2 (esp32_4MB_V4_M) ==="
file /tmp/build2/FastLED_no_fastled/FastLED.cpp.o 2>/dev/null || echo "File not found"

echo ""
echo "=== Hex dump of first 32 bytes of build1 FastLED.cpp.o ==="
xxd -l 32 /tmp/build1/FastLED_no_fastled/FastLED.cpp.o 2>/dev/null || echo "File not found"

echo ""
echo "=== Hex dump of first 32 bytes of build2 FastLED.cpp.o ==="
xxd -l 32 /tmp/build2/FastLED_no_fastled/FastLED.cpp.o 2>/dev/null || echo "File not found"

Length of output: 1061

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 -c "
import json

with open('/tmp/build1_compile_commands.json') as f:
    b1 = json.load(f)

with open('/tmp/build2_compile_commands.json') as f:
    b2 = json.load(f)

# Find FastLED.cpp entries
print('=== Build1 (esp32dev_compat) FastLED.cpp compile command ===')
for entry in b1:
    if 'FastLED.cpp' in entry.get('file','') and 'FastLED_no_fastled' in entry.get('file',''):
        print('File:', entry['file'])
        print('Command:', entry['command'])
        print('Directory:', entry.get('directory',''))
        break

print()
print('=== Build2 (esp32_4MB_V4_M) FastLED.cpp compile command ===')
for entry in b2:
    if 'FastLED.cpp' in entry.get('file','') and 'FastLED_no_fastled' in entry.get('file',''):
        print('File:', entry['file'])
        print('Command:', entry['command'])
        print('Directory:', entry.get('directory',''))
        break
"

Length of output: 32019

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 -c "
import json

with open('/tmp/build1_compile_commands.json') as f:
    b1 = json.load(f)

with open('/tmp/build2_compile_commands.json') as f:
    b2 = json.load(f)

# Get ALL compilers used across both builds
print('=== Build1 (esp32dev_compat) - unique compiler binaries ===')
compilers1 = set()
for entry in b1:
    cmd = entry.get('command','')
    compiler = cmd.split()[0] if cmd else ''
    compilers1.add(compiler)
for c in sorted(compilers1):
    print(' ', c)

print()
print('=== Build2 (esp32_4MB_V4_M) - unique compiler binaries ===')
compilers2 = set()
for entry in b2:
    cmd = entry.get('command','')
    compiler = cmd.split()[0] if cmd else ''
    compilers2.add(compiler)
for c in sorted(compilers2):
    print(' ', c)

print()
# Check specifically if any FastLED files in build1 use different compiler
print('=== Build1: compilers used for FastLED_no_fastled files ===')
for entry in b1:
    f = entry.get('file','')
    if 'FastLED_no_fastled' in f:
        cmd = entry.get('command','')
        compiler = cmd.split()[0] if cmd else ''
        print(f'  {compiler}  ->  {f}')

print()
print('=== Build2: compilers used for FastLED_no_fastled files ===')
for entry in b2:
    f = entry.get('file','')
    if 'FastLED_no_fastled' in f:
        cmd = entry.get('command','')
        compiler = cmd.split()[0] if cmd else ''
        print(f'  {compiler}  ->  {f}')
"

Length of output: 6014

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Fetch PR `#331` diff to see platformio.ini changes in detail
gh pr diff 331 --repo MoonModules/WLED-MM -- platformio.ini

Length of output: 431

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Fetch the patch_audioreactive.py introduced in PR `#331`
gh pr diff 331 --repo MoonModules/WLED-MM -- pio-scripts/patch_audioreactive.py

Length of output: 447

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== PR `#331` full diff ==="
gh api repos/MoonModules/WLED-MM/pulls/331/files | jq -r '.[] | select(.filename == "platformio.ini") | .patch'

Length of output: 4704

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== PR `#331` patch_audioreactive.py patch ==="
gh api repos/MoonModules/WLED-MM/pulls/331/files | jq -r '.[] | select(.filename == "pio-scripts/patch_audioreactive.py") | .patch'

Length of output: 1903

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify the -M flag theory by checking build1 compile commands more carefully
python3 -c "
import json

with open('/tmp/build1_compile_commands.json') as f:
    b1 = json.load(f)
with open('/tmp/build2_compile_commands.json') as f:
    b2 = json.load(f)

# Count how many build1 commands have -M flag (standalone, not -MMD or -MF)
import re
b1_with_M = sum(1 for e in b1 if re.search(r'\s-M\s', e.get('command','')))
b1_with_MMD = sum(1 for e in b1 if '-MMD' in e.get('command',''))
b2_with_M = sum(1 for e in b2 if re.search(r'\s-M\s', e.get('command','')))
b2_with_MMD = sum(1 for e in b2 if '-MMD' in e.get('command',''))

print(f'Build1 entries with standalone -M flag: {b1_with_M} out of {len(b1)}')
print(f'Build1 entries with -MMD flag: {b1_with_MMD} out of {len(b1)}')
print(f'Build2 entries with standalone -M flag: {b2_with_M} out of {len(b2)}')
print(f'Build2 entries with -MMD flag: {b2_with_MMD} out of {len(b2)}')

# Show the exact -M flag context for build1
print()
print('Build1 FastLED.cpp command snippet around -M flag:')
for e in b1:
    if 'FastLED.cpp' in e.get('file','') and re.search(r'\s-M\s', e.get('command','')):
        cmd = e['command']
        idx = cmd.find(' -M ')
        print(repr(cmd[max(0,idx-50):idx+80]))
        break
"

Length of output: 1722

---

---

@softhack007 I have a definitive root cause. The evidence is conclusive.

---

Root Cause: Typo -M WLEDMM instead of -D WLEDMM in platformio.ini

The Smoking Gun in PR #331

In the platformio.ini diff, inside the esp32dev_compat-related section (around line 422):

-AR_build_flags = ${common_mm.AR_build_flags}
+AR_build_flags = ${common_mm.AR_build_flags} -M WLEDMM

The intent was almost certainly -D WLEDMM (define a preprocessor macro), but -M is an entirely different GCC flag.

What -M Does vs What Was Intended

Flag	Effect
-D WLEDMM	Defines the C preprocessor macro WLEDMM — normal compilation proceeds
-M WLEDMM	Tells the compiler to emit make-style dependency rules (list of headers) to the output file — no ELF object is produced

When GCC sees -M, it writes a text file like:

FastLED.cpp.o: FastLED.cpp FastLED.h clockless.h ...

...into the .o output file instead of compiling to machine code.

Evidence from the Build Artifacts

Metric	esp32dev_compat (broken)	esp32_4MB_V4_M (working)
Compiler toolchain	toolchain-xtensa32	toolchain-xtensa-esp32
Entries with standalone -M	288 / 289	0 / 340
Entries with -MMD	0	338 / 340
FastLED.cpp.o size	25,439 bytes (text)	85,952 bytes (ELF binary)
All .o sizes	Suspiciously uniform ~25 KB	Varied 84–312 KB (real code)

Every single .o file in the esp32dev_compat build is a ~25 KB text file (make dependency listing), not an ELF binary. The linker then tries to process them and fails:

ld: FastLED.cpp.o: file format not recognized; treating as linker script
ld: FastLED.cpp.o:1: syntax error

Why Only esp32dev_compat?

The -M WLEDMM typo was only appended to the AR_build_flags in the esp32dev_compat section. Other envs (like esp32_4MB_V4_M) inherit AR_build_flags differently and were not affected.

Additional Note

-D WLEDMM is already present inside common_mm.AR_build_flags (also added in PR #331), so the appended -M WLEDMM is both a typo and redundant.

Fix

In platformio.ini, remove the -M WLEDMM entirely from that line (since -D WLEDMM is already covered by ${common_mm.AR_build_flags}):

-AR_build_flags = ${common_mm.AR_build_flags} -M WLEDMM
+AR_build_flags = ${common_mm.AR_build_flags}

[softhack007]

@coderabbitai thanks, well spotted. The CI build in mdev works again after applying the change you suggest. Please double-check if the patch_audioreactive.py added with #331 can have unexpected side effects.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== patch_audioreactive.py content ==="
gh api repos/MoonModules/WLED-MM/contents/pio-scripts/patch_audioreactive.py?ref=mdev \
  | jq -r '.content' | base64 -d

echo ""
echo "=== How it is referenced in platformio.ini ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | grep -n "patch_audioreactive\|extra_scripts" | head -40

Length of output: 2215

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== PR `#331` patch for patch_audioreactive.py ==="
gh api repos/MoonModules/WLED-MM/pulls/331/files \
  | jq -r '.[] | select(.filename == "pio-scripts/patch_audioreactive.py") | .patch'

echo ""
echo "=== PR `#331` patch for platformio.ini (extra_scripts context) ==="
gh api repos/MoonModules/WLED-MM/pulls/331/files \
  | jq -r '.[] | select(.filename == "platformio.ini") | .patch' \
  | grep -A5 -B5 "patch_audioreactive\|extra_scripts"

Length of output: 2658

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== wled-audioreactive library.json from the git repo (if tracked) ==="
gh api repos/MoonModules/wled-audioreactive/contents/library.json 2>/dev/null \
  | jq -r '.content' | base64 -d || echo "Not found in repo root"

echo ""
echo "=== Check if wled-audioreactive has a library.json at all ==="
gh api repos/MoonModules/wled-audioreactive/git/trees/HEAD?recursive=1 2>/dev/null \
  | jq -r '.tree[].path' | grep -i "library.json" || echo "No library.json found"

echo ""
echo "=== platformio.ini: full scripts_defaults section ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d \
  | awk '/^\[scripts_defaults\]/,/^\[/' | head -60

echo ""
echo "=== platformio.ini: lib_deps referencing wled-audioreactive ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d \
  | grep -n "audioreactive" | head -20

Length of output: 2996

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Get the full platformio.ini and extract the scripts_defaults section properly
content=$(gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev | jq -r '.content' | base64 -d)

echo "=== scripts_defaults section ==="
echo "$content" | python3 -c "
import sys, re
text = sys.stdin.read()
# Extract sections
m = re.search(r'(\[scripts_defaults\].*?)(?=\n\[)', text, re.DOTALL)
if m: print(m.group(1))
else: print('NOT FOUND')
"

echo ""
echo "=== extra_scripts in scripts_defaults ==="
echo "$content" | python3 -c "
import sys, re
text = sys.stdin.read()
m = re.search(r'\[scripts_defaults\](.*?)(?=\n\[)', text, re.DOTALL)
if m:
    section = m.group(1)
    e = re.search(r'extra_scripts\s*=(.*?)(?=\n\S|\Z)', section, re.DOTALL)
    if e: print(e.group(0))
"

echo ""
echo "=== How wled-audioreactive is declared as a lib_dep ==="
echo "$content" | grep -n "wled-audioreactive" | head -20

echo ""
echo "=== AR_build_flags definition in common_mm ==="
echo "$content" | python3 -c "
import sys, re
text = sys.stdin.read()
# Find AR_build_flags
for m in re.finditer(r'AR_build_flags\s*=.*', text):
    line_no = text[:m.start()].count('\n') + 1
    print(f'Line {line_no}: {m.group(0)[:200]}')
"

echo ""
echo "=== Lines 1210-1230 of platformio.ini (around wled-audioreactive include) ==="
echo "$content" | sed -n '1210,1230p'

Length of output: 4445

---

---

@softhack007 Glad the fix worked! 🐇 ✨

Here's the analysis of patch_audioreactive.py. The script is broadly sound in intent — it correctly patches PlatformIO's auto-generated library.json to add "srcFilter": ["-<*>"], which prevents the wled-audioreactive library's .cpp files from being compiled as a library unit (since they are compiled directly as part of the main project). The os.path.exists() guard and the idempotency check (if "srcFilter" not in library_config["build"]) are also good. That said, there are several potential side-effect risks:

---

Risk 1 — Silent failure leads to confusing linker errors (highest impact)

except Exception as e:
    print(f"Warning: Could not patch wled-audioreactive library.json: {e}")

Any failure (JSON parse error, I/O permissions, encoding issue) is swallowed with only a warning. The build then continues with the library unpatched, and the .cpp files are compiled both as library sources and as main-project sources → the linker throws duplicate symbol errors with no clear indication the patch is to blame.

Suggestion: treat patch failure as a fatal build error:

except Exception as e:
    import sys
    print(f"ERROR: Could not patch wled-audioreactive library.json: {e}", file=sys.stderr)
    env.Exit(1)

---

Risk 2 — Guard bypassed if library ships its own srcFilter

if "srcFilter" not in library_config["build"]:
    library_config["build"]["srcFilter"] = ["-<*>"]

If a future version of wled-audioreactive ships its own library.json with a build.srcFilter already set to something else (e.g., include only selected files), the script silently does nothing. The required "-<*>" is never applied → same duplicate-symbol failure, with no warning at all.

Suggestion: always overwrite (or at least warn when the existing value differs):

if library_config["build"].get("srcFilter") != ["-<*>"]:
    library_config["build"]["srcFilter"] = ["-<*>"]
    # ... write file

---

Risk 3 — Missing library.json on a clean build (cold CI cache)

If PlatformIO somehow doesn't auto-generate library.json for the fetched library (edge case with certain PlatformIO versions or install modes), os.path.exists() returns False, the patch is silently skipped, and the build fails at link time. This is unlikely but worth noting for CI cold-cache scenarios.

---

Risk 4 — Fragile malformed-JSON "fix"

if not content.strip().startswith('{'):
    content = '{' + content
if not content.strip().endswith('}'):
    content = content + '}'

This is overly naive:

• A UTF-8 BOM (\xef\xbb\xbf) at the start would survive strip(), causing startswith('{') to fail and prepending a { → corrupted JSON.
• A valid JSON array ([…]) would be incorrectly wrapped.

Since PlatformIO auto-generates this file as valid JSON, the malformed-JSON handling is probably dead code from an older workaround. It would be safer to either remove it or handle the BOM explicitly.

---

Risk 5 — Environments that override extra_scripts entirely

The patch is registered in scripts_defaults.extra_scripts. Any environment that declares extra_scripts = … directly (without ${scripts_defaults.extra_scripts}) will not run the patch and will silently get duplicate-symbol failures when AudioReactive is included. There don't appear to be any such envs currently, but it's a maintenance trap if new envs are added.

---

Summary table

Risk	Likelihood	Impact	Mitigation
Silent exception → duplicate symbols	Low–Medium	High	Fail build on exception
Pre-existing srcFilter bypasses patch	Low (currently)	High	Always overwrite / warn on mismatch
Missing library.json on cold cache	Low	High	Log clearly if file absent
Naive malformed-JSON handling	Very low	Low	Remove or fix BOM handling
Env not inheriting scripts_defaults	Low	High	Document requirement

The most actionable fix is Risk 1 (turn the silent warning into a fatal error) — all other risks manifest as hard-to-diagnose linker failures, but at least a fatal error on patch failure would point developers directly at this script.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== patch_audioreactive.py (mdev branch) ==="
gh api repos/MoonModules/WLED-MM/contents/pio-scripts/patch_audioreactive.py?ref=mdev \
  | jq -r '.content' | base64 -d

echo ""
echo "=== platformio.ini sections referencing patch_audioreactive ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | grep -n "patch_audioreactive" || true

echo ""
echo "=== All extra_scripts lines in platformio.ini ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | grep -n "extra_scripts" || true

Length of output: 2495

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== platformio.ini lines 235-265 ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | sed -n '235,265p' | nl -ba -v235

echo ""
echo "=== platformio.ini lines 290-310 ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | sed -n '290,310p' | nl -ba -v290

echo ""
echo "=== Look for wled-audioreactive library.json in the repo ==="
gh api repos/MoonModules/wled-audioreactive/contents/library.json 2>/dev/null \
  | jq -r '.content' | base64 -d | head -60 || echo "Not found or different repo name"

# Try alternate names
echo ""
echo "=== Check lib_deps for audioreactive in platformio.ini ==="
gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev \
  | jq -r '.content' | base64 -d | grep -i "audioreactive" | head -20 || true

Length of output: 1207

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

PIO=$(gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev | jq -r '.content' | base64 -d)

echo "=== platformio.ini lines 230-270 ==="
echo "$PIO" | awk 'NR>=230 && NR<=270 {printf "%d: %s\n", NR, $0}'

echo ""
echo "=== platformio.ini lines 290-315 ==="
echo "$PIO" | awk 'NR>=290 && NR<=315 {printf "%d: %s\n", NR, $0}'

echo ""
echo "=== all lib_deps lines mentioning audioreactive ==="
echo "$PIO" | grep -in "audioreactive" || true

echo ""
echo "=== wled-audioreactive library.json from MoonModules org ==="
gh api repos/MoonModules/wled-audioreactive/contents/library.json 2>/dev/null \
  | jq -r '.content' | base64 -d || echo "Repo not found under MoonModules"

echo ""
echo "=== search GitHub for wled-audioreactive library.json ==="
gh api "search/code?q=wled-audioreactive+filename:library.json+org:MoonModules" 2>/dev/null \
  | jq -r '.items[].html_url' || true

Length of output: 6849

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== wled-audioreactive library.json (from WLED-AudioReactive-Usermod repo) ==="
gh api repos/MoonModules/WLED-AudioReactive-Usermod/contents/library.json 2>/dev/null \
  | jq -r '.content' | base64 -d || echo "Not found at root"

echo ""
echo "=== Try specific commit 171c0bbc2bc47e2c11ae203dd00beed82865df2b ==="
gh api "repos/MoonModules/WLED-AudioReactive-Usermod/contents/library.json?ref=171c0bbc2bc47e2c11ae203dd00beed82865df2b" 2>/dev/null \
  | jq -r '.content' | base64 -d || echo "Not found at that ref"

echo ""
echo "=== platformio.ini: envs with their own extra_scripts (not inheriting scripts_defaults) ==="
PIO=$(gh api repos/MoonModules/WLED-MM/contents/platformio.ini?ref=mdev | jq -r '.content' | base64 -d)
# Find lines with extra_scripts that are NOT the scripts_defaults block and NOT the ${scripts_defaults.extra_scripts} inherit
echo "$PIO" | awk 'NR>=300' | grep -n "extra_scripts" | grep -v "scripts_defaults" || echo "none found"

echo ""
echo "=== Lines around the audioreactive env definition (lines 1205-1230) ==="
echo "$PIO" | awk 'NR>=1205 && NR<=1230 {printf "%d: %s\n", NR, $0}'

Length of output: 3909

---

---

@softhack007 Glad the fix worked! Here's a full analysis of patch_audioreactive.py for unexpected side effects.

---

Analysis of patch_audioreactive.py

What it does

It mutates wled-audioreactive/library.json in the PlatformIO libdeps cache by injecting "srcFilter": ["-<*>"] under the "build" key. This prevents PlatformIO from compiling the library's .cpp files as a standalone library unit — they must instead be #included directly from the main project (which is how WLED-MM's AudioReactive integration works, as confirmed by line 1215–1216 in platformio.ini).

The current upstream library.json at the pinned commit 171c0bbc is:

{
  "name": "wled-audioreactive",
  "build": {
    "libArchive": false,
    "extraScript": "override_sqrt.py"
  },
  "dependencies": [...]
}

There is no srcFilter in it, so the patch will always apply on first build.

---

No issues found ✅

Aspect	Status
"extraScript": "override_sqrt.py" preserved after patching	✅ json.dump preserves all existing keys
override_sqrt.py continues to run	✅ PlatformIO processes extraScript independently of srcFilter
Non-AudioReactive envs are unaffected	✅ os.path.exists() returns False → no-op
All envs run the script	✅ All inherit ${scripts_defaults.extra_scripts}; none define their own
Idempotency: patch won't double-apply	✅ Guarded by if "srcFilter" not in library_config["build"]
Library pinned to a commit hash	✅ Protects against unexpected upstream changes disrupting the patch

---

Risks worth noting ⚠️

1. Silent failure → confusing linker errors
   The except Exception as e block only prints a warning and lets the build continue. If JSON parsing fails for any reason (encoding, BOM, permissions), the .cpp files compile both as library and via #include → duplicate-symbol linker errors — very confusing to diagnose. Consider raising instead:

   except Exception as e:
       raise RuntimeError(f"FATAL: Could not patch wled-audioreactive library.json: {e}")

2. Future upstream srcFilter addition bypasses the patch
   The guard if "srcFilter" not in library_config["build"] means that if the upstream library.json ever ships its own srcFilter value (even a wrong one), the patch is silently skipped. This is the correct behavior if the upstream value matches WLED-MM's expectation, but could be a hidden failure mode if it doesn't. Line 1219's comment acknowledges this:

   NOTE: External repo needs library.json updated with "srcFilter": ["-<*>"]...
   The proper long-term fix would be to submit a PR to the upstream WLED-AudioReactive-Usermod repo to include "srcFilter": ["-<*>"] directly in library.json, making this patch script unnecessary.

3. Fragile malformed-JSON repair (low risk currently)
   The heuristic that prepends { or appends } won't be triggered by the current well-formed library.json, but it's risky defensive code — any future library format change (e.g., JSONC with // comments) would silently corrupt the file rather than failing loudly.

---

TL;DR

The script works correctly for the current state of the codebase with no unexpected side effects. The main actionable improvement is converting the silent except to a hard failure to make future breakage easier to diagnose.

🐇 ✨