remove unused step

Author: anthony-nhs

.github/workflows/ci.yml

@@ -8,39 +8,21 @@ env:
   BRANCH_NAME: ${{ github.ref_name }}
 
 jobs:
-  get_commit_id:
-    runs-on: ubuntu-22.04
-    outputs:
-      commit_id: ${{ steps.commit_id.outputs.commit_id }}
-      sha_short: ${{ steps.commit_id.outputs.sha_short }}
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
-        with:
-          ref: ${{ env.BRANCH_NAME }}
-
-      - name: Get Commit ID
-        id: commit_id
-        run: |
-          #  echo "commit_id=${{ github.sha }}" >> "$GITHUB_ENV"
-          echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
-          echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
   get_config_values:
     uses: NHSDigital/eps-common-workflows/.github/workflows/get-repo-config.yml@b0172dbdb3af4ae232873106553c316d79d784fc
     with:
       verify_published_from_main_image: true
   quality_checks:
     uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
-    needs: [get_config_values, get_commit_id]
+    needs: [get_config_values]
     with:
       pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
       run_docker_scan: false
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
   tag_release:
-    needs: [quality_checks, get_commit_id, get_config_values]
+    needs: [quality_checks, get_config_values]
     uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
     with:
       dry_run: true
@@ -51,7 +33,7 @@ jobs:
     secrets: inherit
 
   package_npm_code:
-    needs: [quality_checks, get_commit_id, get_config_values]
+    needs: [quality_checks, get_config_values]
     uses: ./.github/workflows/package_npm_code.yml
     with:
       pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}

.github/workflows/pull_request.yml

@@ -22,7 +22,7 @@ jobs:
     uses: NHSDigital/eps-common-workflows/.github/workflows/pr_title_check.yml@b0172dbdb3af4ae232873106553c316d79d784fc
   quality_checks:
     uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
-    needs: [get_config_values, get_commit_id]
+    needs: [get_config_values]
     with:
       pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
       run_docker_scan: false
@@ -56,31 +56,15 @@ jobs:
             }
           result-encoding: string
 
-  get_commit_id:
-    runs-on: ubuntu-22.04
-    outputs:
-      commit_id: ${{ steps.commit_id.outputs.commit_id }}
-      sha_short: ${{ steps.commit_id.outputs.sha_short }}
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
-        with:
-          ref: ${{ env.BRANCH_NAME }}
-
-      - name: Get Commit ID
-        id: commit_id
-        run: |
-          echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
-          echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
 
   package_npm_code:
-    needs: [quality_checks, get_commit_id, get_config_values]
+    needs: [quality_checks, get_config_values]
     uses: ./.github/workflows/package_npm_code.yml
     with:
       pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
 
   tag_release:
-    needs: [get_commit_id, get_config_values]
+    needs: [get_config_values]
     uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
     with:
       dry_run: true

.github/workflows/release.yml

@@ -13,35 +13,17 @@ jobs:
     uses: NHSDigital/eps-common-workflows/.github/workflows/get-repo-config.yml@b0172dbdb3af4ae232873106553c316d79d784fc
     with:
       verify_published_from_main_image: true
-  get_commit_id:
-    runs-on: ubuntu-22.04
-    outputs:
-      commit_id: ${{ steps.commit_id.outputs.commit_id }}
-      sha_short: ${{ steps.commit_id.outputs.sha_short }}
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
-        with:
-          ref: ${{ env.BRANCH_NAME }}
-
-      - name: Get Commit ID
-        id: commit_id
-        run: |
-          #  echo "commit_id=${{ github.sha }}" >> "$GITHUB_ENV"
-          echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
-          echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
   quality_checks:
     uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
-    needs: [get_config_values, get_commit_id]
+    needs: [get_config_values]
     with:
       pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
       run_docker_scan: false
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
   tag_release:
-    needs: [quality_checks, get_commit_id, get_config_values]
+    needs: [quality_checks, get_config_values]
     uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
     with:
       dry_run: false