fix sonar issues

Author: anthony-nhs

packages/cdkConstructs/src/constructs/PythonLambdaFunction.ts

@@ -15,7 +15,7 @@ import {
   Code,
   ILayerVersion
 } from "aws-cdk-lib/aws-lambda"
-import {join} from "path"
+import {join} from "node:path"
 import {createSharedLambdaResources} from "./lambdaSharedResources"
 
 export interface PythonLambdaFunctionProps {

packages/cdkConstructs/src/utils/helpers.ts

@@ -67,9 +67,7 @@ export function findCloudFormationResourcesByType(construct: IConstruct, type: s
  */
 export function addSuppressions(resources: Array<CfnResource>, rules: Array<string>): void {
   resources.forEach(resource => {
-    if (!resource.cfnOptions.metadata) {
-      resource.cfnOptions.metadata = {}
-    }
+    resource.cfnOptions.metadata ??= {}
     const existing = resource.cfnOptions.metadata.guard?.SuppressedRules || []
     const combined = Array.from(new Set([...existing, ...rules]))
     resource.cfnOptions.metadata.guard = {SuppressedRules: combined}

packages/cdkConstructs/tests/utils/helpers.test.ts

@@ -16,7 +16,7 @@ const defaultSuppressionRules = ["LAMBDA_DLQ_CHECK", "LAMBDA_INSIDE_VPC", "LAMBD
 const createResource = (stack: Stack, id: string, type = "Custom::Test", path?: string): CfnResource => {
   const resource = new CfnResource(stack, id, {type, properties: {}})
   resource.cfnOptions.metadata = {
-    ...(resource.cfnOptions.metadata ?? {}),
+    ...(resource.cfnOptions.metadata),
     "aws:cdk:path": path ?? `${stack.stackName}/${id}`
   }
   return resource