Fixed security setting for proxygen PR deploys

Author: MatthewPopat-NHS

packages/deploymentUtils/src/specifications/fixSpec.ts

@@ -46,15 +46,12 @@ export function fixSpec({
     instance = `${apiName}-pr-${pr_id}`
     spec.info.title = `[PR-${pr_id}] ${spec.info.title}`
     spec["x-nhsd-apim"].monitoring = false
-    delete spec["x-nhsd-apim"].target.security.secret
-  } else {
-    if (blueGreen) {
-      stack = calculateVersionedStackName(stackName, version)
-    }
-    spec["x-nhsd-apim"].target.security.secret = mtlsSecretName
+  } else if (blueGreen) {
+    stack = calculateVersionedStackName(stackName, version)
   }
   spec.info.version = version
   spec["x-nhsd-apim"].target.url = `https://${stack}.${awsEnvironment}.eps.national.nhs.uk`
+  spec["x-nhsd-apim"].target.security.secret = mtlsSecretName
   if (apigeeEnvironment === "prod") {
     spec.servers = [ {url: `https://api.service.nhs.uk/${instance}`} ]
     replaceSchemeRefs(spec, "proxygen.prod.api.platform.nhs.uk")

packages/deploymentUtils/tests/specifications/fixSpec.test.ts

@@ -71,7 +71,6 @@ describe("fixSpec", () => {
     expect(instance).toBe("eps-pr-456")
     expect(spec.info.title).toBe("[PR-456] EPS API")
     expect(spec["x-nhsd-apim"].monitoring).toBe(false)
-    expect(spec["x-nhsd-apim"].target.security.secret).toBeUndefined()
     expect(spec["x-nhsd-apim"]["target-attributes"]).toBeUndefined()
     expect(spec.servers[0].url)
       .toBe("https://sandbox.api.service.nhs.uk/eps-pr-456")