always push image

Author: anthony-nhs

.github/workflows/build_all_images.yml

@@ -8,9 +8,6 @@ name: build_all_images
       tag_latest:
         required: true
         type: boolean
-      push_image:
-        required: true
-        type: boolean
 env:
   BRANCH_NAME: '${{ github.event.pull_request.head.ref }}'
 jobs:
@@ -35,7 +32,6 @@ jobs:
       docker_tag: ${{ inputs.docker_tag }}
       container_name: base
       base_folder: "."
-      push_image: ${{ inputs.push_image }}
   package_language_docker_images:
     needs:
       - package_base_docker_image
@@ -50,7 +46,6 @@ jobs:
       docker_tag: ${{ inputs.docker_tag }}
       container_name: ${{ matrix.container_name }}
       base_folder: "languages"
-      push_image: ${{ inputs.push_image }}
   package_project_docker_images:
     needs:
       - package_language_docker_images
@@ -66,4 +61,3 @@ jobs:
       docker_tag: ${{ inputs.docker_tag }}
       container_name: ${{ matrix.container_name }}
       base_folder: "projects"
-      push_image: ${{ inputs.push_image }}

.github/workflows/build_multi_arch_image.yml

@@ -14,9 +14,6 @@ name: Build and push docker image
       base_folder:
         required: true
         type: string
-      push_image:
-        required: true
-        type: boolean
 
 jobs:
   build_and_push_image:
@@ -67,25 +64,6 @@ jobs:
       - name: make install
         run: |
           make install-node
-      - name: Download images
-        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
-        if: ${{ !inputs.push_image }}
-        with:
-          pattern: eps-devcontainer-*.img
-      - name: Extract images
-        if: ${{ !inputs.push_image }}
-        run: |
-            shopt -s nullglob
-            imgs=(eps-devcontainer-*.img)
-            if [ ${#imgs[@]} -eq 0 ]; then
-              echo "No images found to load."
-            else
-            for img in "${imgs[@]}"; do
-              echo "Loading image from $img..."
-              docker load -i "$img"
-              rm "$img"
-            done
-            fi
 
       - name: Build container
         run: |
@@ -150,7 +128,6 @@ jobs:
           ARCHITECTURE: '${{ matrix.arch }}'
           DOCKER_TAG: '${{ inputs.docker_tag }}'
       - name: Push tagged image
-        if: ${{ inputs.push_image }}
         run: |
           echo "Pushing image..."
           docker push "ghcr.io/nhsdigital/eps-devcontainers/${CONTAINER_NAME}:${DOCKER_TAG}-${ARCHITECTURE}"
@@ -159,7 +136,7 @@ jobs:
           CONTAINER_NAME: '${{ inputs.container_name }}'
           ARCHITECTURE: '${{ matrix.arch }}'
       - name: Push latest image
-        if: ${{ inputs.tag_latest && inputs.push_image }}
+        if: ${{ inputs.tag_latest }}
         run: |
           docker tag "ghcr.io/nhsdigital/eps-devcontainers/${CONTAINER_NAME}:${DOCKER_TAG}-${ARCHITECTURE}" "ghcr.io/nhsdigital/eps-devcontainers/${CONTAINER_NAME}:latest-${ARCHITECTURE}"
           echo "Pushing image..."
@@ -168,25 +145,8 @@ jobs:
           DOCKER_TAG: ${{ inputs.docker_tag }}
           CONTAINER_NAME: '${{ inputs.container_name }}'
           ARCHITECTURE: '${{ matrix.arch }}'
-      - name: Save image for upload
-        if: ${{ !inputs.push_image }}
-        run: |
-          docker save "ghcr.io/nhsdigital/eps-devcontainers/${CONTAINER_NAME}:${DOCKER_TAG}-${ARCHITECTURE}" -o "eps-devcontainer-${CONTAINER_NAME}-${DOCKER_TAG}-${ARCHITECTURE}.img"
-        env:
-          ARCHITECTURE: '${{ matrix.arch }}'
-          DOCKER_TAG: '${{ inputs.docker_tag }}'
-          CONTAINER_NAME: '${{ inputs.container_name }}'
-          BASE_VERSION: ${{ inputs.docker_tag}}
-      - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
-        name: Upload docker images
-        if: ${{ !inputs.push_image }}
-        with:
-          name: "eps-devcontainer-${{ inputs.container_name }}-${{ inputs.docker_tag }}-${{ matrix.arch }}.img"
-          path: |
-            eps-devcontainer-${{ inputs.container_name }}-${{ inputs.docker_tag }}-${{ matrix.arch }}.img
   publish_combined_image:
-    if: ${{ inputs.push_image }}
-    name: Publish image for ${{ inputs.container_name }}
+    name: Publish combined image for ${{ inputs.container_name }}
     runs-on: ubuntu-22.04
     needs: build_and_push_image
     permissions:

.github/workflows/ci.yml

@@ -45,4 +45,3 @@ jobs:
     with: 
       docker_tag: '${{ needs.tag_release.outputs.version_tag }}'
       tag_latest: false
-      push_image: false

.github/workflows/pull_request.yml

@@ -92,4 +92,3 @@ jobs:
     with: 
       docker_tag: 'pr-${{ needs.get_issue_number.outputs.issue_number }}-${{ needs.get_commit_id.outputs.sha_short }}'
       tag_latest: false
-      push_image: false

.github/workflows/release.yml

@@ -46,4 +46,3 @@ jobs:
     with: 
       docker_tag: '${{ needs.tag_release.outputs.version_tag }}'
       tag_latest: true
-      push_image: true