Chore: [AEA-0000] - add standard lifecycle scripts (#76)

## Summary

- 🤖 Operational or Infrastructure Change

### Details

- Add standard lifecycle event scripts to base container.
- Make the installation of git secrets work the same on fresh clone or
existing
  - move to postCreate so it does not try to run on every start
  - test if already installed.

---------

Co-authored-by: Tim Stephenson <tim@knowprocess.com>

Author: tstephen-nhs

.devcontainer/devcontainer.json

@@ -22,7 +22,9 @@
       "--network=host"
     ],
     "remoteEnv": { "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" },
-  "postAttachCommand": "git-secrets --register-aws; git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt",
+    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
+    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
+    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {
     },
     "customizations": {

Makefile

@@ -65,8 +65,12 @@ build-all: build-base-image build-node-24-image build-node-24-python-3-10-image
 	build-regression-tests-image
 
 build-image: guard-CONTAINER_NAME guard-BASE_VERSION_TAG guard-BASE_FOLDER guard-IMAGE_TAG
+	workspace_folder="$${CONTAINER_NAME}"; \
+	case "$${CONTAINER_NAME}" in \
+		eps_*) workspace_folder="$$(printf '%s' "$${CONTAINER_NAME}" | tr '_' '-')" ;; \
+	esac; \
 	npx devcontainer build \
-		--workspace-folder ./src/$${BASE_FOLDER}/$${CONTAINER_NAME} \
+		--workspace-folder ./src/$${BASE_FOLDER}/$${workspace_folder} \
 		$(NO_CACHE_FLAG) \
 		--push false \
 		--output type=image,name="${CONTAINER_PREFIX}$${CONTAINER_NAME}:$${IMAGE_TAG}",push=false,compression=zstd \

src/base/.devcontainer/Dockerfile

@@ -21,6 +21,7 @@ ENV CONTAINER_NAME=${CONTAINER_NAME}
 ENV TARGETARCH=${TARGETARCH}
 
 COPY .tool-versions.asdf ${SCRIPTS_DIR}/${CONTAINER_NAME}/.tool-versions.asdf
+COPY --chmod=755 scripts/lifecycle/*.sh ${SCRIPTS_DIR}/
 COPY --chmod=755 scripts/root_install.sh ${SCRIPTS_DIR}/${CONTAINER_NAME}/root_install.sh
 COPY --chmod=755 Mk ${SCRIPTS_DIR}/Mk
 

src/base/.devcontainer/devcontainer.json

@@ -12,6 +12,9 @@
         "IMAGE_TAG": "${localEnv:IMAGE_TAG}"
       }
     },
+    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
+    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
+    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {
       "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
         "version": "latest",

src/base/.devcontainer/scripts/lifecycle/post_attach.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+# Script to run as devcontainer postAttachCommand
+set -euo pipefail
+
+# currently empty

src/base/.devcontainer/scripts/lifecycle/post_create.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+# Script to run as devcontainer postCreateCommand
+set -euo pipefail
+
+# Install git-secrets, register AWS patterns and NHS rules in an idempotent way
+if ! git config --get-all secrets.patterns | grep -Fq AKIA; then
+  git-secrets --register-aws
+fi
+if ! git config --get-all secrets.providers | grep -Fxq "cat /usr/share/secrets-scanner/nhsd-rules-deny.txt"; then
+  git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt
+fi

src/base/.devcontainer/scripts/lifecycle/post_start.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+# Script to run as devcontainer postStartCommand
+set -euo pipefail
+
+# currently empty

src/base_node/node_24/.devcontainer/devcontainer.json

@@ -13,6 +13,9 @@
       },
       "context": "."
     },
+    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
+    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
+    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
 

src/languages/node_24_python_3_10/.devcontainer/devcontainer.json

@@ -13,6 +13,9 @@
       },
       "context": "."
     },
+    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
+    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
+    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
 

src/languages/node_24_python_3_12/.devcontainer/devcontainer.json

@@ -13,6 +13,9 @@
       },
       "context": "."
     },
+    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
+    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
+    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }