only run post* scripts once

anthony-nhs · anthony-nhs · commit d7ffa26bc24d · 2026-03-31T09:52:51.000Z
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -22,9 +22,6 @@
       "--network=host"
     ],
     "remoteEnv": { "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {
     },
     "customizations": {
diff --git a/src/base/.devcontainer/scripts/lifecycle/post_attach.sh b/src/base/.devcontainer/scripts/lifecycle/post_attach.sh
@@ -2,4 +2,6 @@
 # Script to run as devcontainer postAttachCommand
 set -euo pipefail
 
+echo "Running common post-attach script"
+
 # currently empty
diff --git a/src/base/.devcontainer/scripts/lifecycle/post_create.sh b/src/base/.devcontainer/scripts/lifecycle/post_create.sh
@@ -2,6 +2,9 @@
 # Script to run as devcontainer postCreateCommand
 set -euo pipefail
 
+echo "Running common post-create script"
+
+
 # Install git-secrets, register AWS patterns and NHS rules in an idempotent way
 if ! git config --get-all secrets.patterns | grep -Fq AKIA; then
   git-secrets --register-aws
diff --git a/src/base/.devcontainer/scripts/lifecycle/post_start.sh b/src/base/.devcontainer/scripts/lifecycle/post_start.sh
@@ -2,4 +2,6 @@
 # Script to run as devcontainer postStartCommand
 set -euo pipefail
 
+echo "Running common post-start script"
+
 # currently empty
diff --git a/src/base_node/node_24/.devcontainer/devcontainer.json b/src/base_node/node_24/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/languages/node_24_python_3_10/.devcontainer/devcontainer.json b/src/languages/node_24_python_3_10/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/languages/node_24_python_3_12/.devcontainer/devcontainer.json b/src/languages/node_24_python_3_12/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/languages/node_24_python_3_13/.devcontainer/devcontainer.json b/src/languages/node_24_python_3_13/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/languages/node_24_python_3_14/.devcontainer/devcontainer.json b/src/languages/node_24_python_3_14/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/eps-data-extract/.devcontainer/devcontainer.json b/src/projects/eps-data-extract/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/eps-storage-terraform/.devcontainer/devcontainer.json b/src/projects/eps-storage-terraform/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/fhir_facade_api/.devcontainer/devcontainer.json b/src/projects/fhir_facade_api/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/node_24_python_3_14_golang_1_24/.devcontainer/devcontainer.json b/src/projects/node_24_python_3_14_golang_1_24/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/node_24_python_3_14_java_24/.devcontainer/devcontainer.json b/src/projects/node_24_python_3_14_java_24/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   
diff --git a/src/projects/regression_tests/.devcontainer/devcontainer.json b/src/projects/regression_tests/.devcontainer/devcontainer.json
@@ -13,9 +13,6 @@
       },
       "context": "."
     },
-    "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",
-    "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",
-    "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",
     "features": {}
   }
   

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,6 @@`
`13`	`13`	`},`
`14`	`14`	`"context": "."`
`15`	`15`	`},`
`16`		`- "postCreateCommand": "bash ${SCRIPTS_DIR}/post_create.sh",`
`17`		`- "postStartCommand": "bash ${SCRIPTS_DIR}/post_start.sh",`
`18`		`- "postAttachCommand": "bash ${SCRIPTS_DIR}/post_attach.sh",`
`19`	`16`	`"features": {}`
`20`	`17`	`}`
`21`	`18`