VED-000: Update ECR repository reference in lambda.tf (#1343)

* Update ECR repository reference in lambda.tf to use the resource name directly

* Update ECR repository reference in lambda.tf to use a formatted name and add dependency on the repository. This change enhances clarity and ensures the Lambda module correctly references the ECR repository for image management.

* Refactor ECR repository reference in lambda.tf to use direct name attribute instead of formatted string. This change improves clarity and ensures accurate dependency management for the Lambda module.

Author: Thomas-Boyle

infrastructure/instance/lambda.tf

@@ -19,7 +19,7 @@ module "docker_image" {
   version = "8.7.0"
 
   create_ecr_repo  = false
-  ecr_repo         = "${local.prefix}-operation-lambda-repo"
+  ecr_repo         = aws_ecr_repository.operation_lambda_repository.name
   docker_file_path = "./backend/Dockerfile"
   ecr_repo_lifecycle_policy = jsonencode({
     "rules" : [