Skip to content

Commit 81018b9

Browse files
authored
Refactor ImmunizationValidator to remove unused reduced validation method (#1267)
- Removed the `is_reduce_validation` static method as it is no longer applicable due to changes in the payload. - Updated the `validate` method to eliminate the check for reduced validation, simplifying the validation flow. - Ensured that post-validation logic remains intact while improving code clarity.
1 parent 83202f6 commit 81018b9

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

lambdas/shared/src/common/models/fhir_immunization.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,11 @@ def run_post_validators(immunization: dict, vaccine_type: str) -> None:
3333
if error := PostValidators(immunization, vaccine_type).validate():
3434
raise ValueError(error)
3535

36-
# VED-1086 TODO: Update this function as reduce_validation_code is no longer found in the payload after data minimisation
37-
@staticmethod
38-
def is_reduce_validation():
39-
"""Identify if reduced validation applies (default to false if no reduce validation information is given)"""
40-
return False
41-
4236
def validate(self, immunization_json_data: dict) -> Immunization:
4337
"""
4438
Generate the Immunization model. Note that run_pre_validators, run_fhir_validators, get_vaccine_type and
4539
run_post_validators will each raise errors if validation is failed.
4640
"""
47-
# Identify whether to apply reduced validation
48-
reduce_validation = self.is_reduce_validation()
49-
5041
# Pre-FHIR validations
5142
self.run_pre_validators(immunization_json_data)
5243

@@ -57,7 +48,7 @@ def validate(self, immunization_json_data: dict) -> Immunization:
5748
vaccine_type = get_vaccine_type(immunization_json_data)
5849

5950
# Post-FHIR validations
60-
if self.add_post_validators and not reduce_validation:
51+
if self.add_post_validators:
6152
self.run_post_validators(immunization_json_data, vaccine_type)
6253

6354
def run_postal_code_validator(self, values: dict) -> None:

0 commit comments

Comments
 (0)