VED-1081-Remove-redundant-V2-to-V5-Identifier-Uplift-code (#1238)

* Removed V@-V5 uplift

* Update error_const

Author: amarauzoma

lambdas/recordprocessor/src/constants.py

@@ -40,11 +40,6 @@
     "LOCATION_CODE_TYPE_URI",
 ]
 
-TPP_V2_SUPPLIER_IDENTIFIER_SYSTEM = "YGA"
-TPP_V5_SUPPLIER_IDENTIFIER_SYSTEM = "https://tpp-uk.com/Id/ve/vacc"
-EMIS_V2_SUPPLIER_IDENTIFIER_SYSTEM = "YGJ"
-EMIS_V5_SUPPLIER_IDENTIFIER_SYSTEM = "https://emishealth.com/identifiers/vacc"
-
 
 class Diagnostics:
     """Diagnostics messages"""

lambdas/recordprocessor/src/process_row.py

@@ -2,10 +2,6 @@
 
 from common.clients import logger
 from constants import (
-    EMIS_V2_SUPPLIER_IDENTIFIER_SYSTEM,
-    EMIS_V5_SUPPLIER_IDENTIFIER_SYSTEM,
-    TPP_V2_SUPPLIER_IDENTIFIER_SYSTEM,
-    TPP_V5_SUPPLIER_IDENTIFIER_SYSTEM,
     Diagnostics,
 )
 from convert_to_fhir_imms_resource import convert_to_fhir_imms_resource
@@ -21,17 +17,6 @@ def process_row(target_disease: list, allowed_operations: set, row: dict) -> dic
     action_flag = (row.get("ACTION_FLAG") or "").upper()
     unique_id_uri = row.get("UNIQUE_ID_URI")
 
-    # This code the relevant constants can be safely removed once DPS carries out it's data migration to update legacy
-    # identifiers as it should become redundant. However, it may be worth keeping in case legacy format identifiers are
-    # received for some reason. Please see issue VED-904 for more information.
-    if unique_id_uri == TPP_V2_SUPPLIER_IDENTIFIER_SYSTEM:
-        unique_id_uri = TPP_V5_SUPPLIER_IDENTIFIER_SYSTEM
-        row["UNIQUE_ID_URI"] = TPP_V5_SUPPLIER_IDENTIFIER_SYSTEM
-
-    if unique_id_uri == EMIS_V2_SUPPLIER_IDENTIFIER_SYSTEM:
-        unique_id_uri = EMIS_V5_SUPPLIER_IDENTIFIER_SYSTEM
-        row["UNIQUE_ID_URI"] = EMIS_V5_SUPPLIER_IDENTIFIER_SYSTEM
-
     unique_id = row.get("UNIQUE_ID")
     local_id = f"{unique_id}^{unique_id_uri}"
 

lambdas/recordprocessor/tests/test_process_row.py

@@ -241,42 +241,6 @@ def test_process_row_missing_unique_id_uri(self):
         )
         self.assertEqual(response["diagnostics"]["statusCode"], 400)
 
-    def test_process_row_successfully_uplifts_legacy_tpp_uri(self):
-        """
-        Test that process_row gives the expected output.
-        These tests check that the row is valid and matches the expected output.
-        """
-        legacy_tpp_row = deepcopy(ROW_DETAILS)
-        legacy_tpp_row["UNIQUE_ID_URI"] = "YGA"
-
-        expected_successful_result_tpp = deepcopy(expected_successful_result)
-        expected_successful_result_tpp["identifier"][0]["system"] = "https://tpp-uk.com/Id/ve/vacc"
-
-        # call 'process_row' with required details
-        imms_fhir_resource = process_row(TargetDiseaseElements.RSV, Allowed_Operations, legacy_tpp_row)
-        # validate if the response with expected result
-        self.assertDictEqual(imms_fhir_resource["fhir_json"], expected_successful_result_tpp)
-        self.assertEqual(legacy_tpp_row["UNIQUE_ID_URI"], "https://tpp-uk.com/Id/ve/vacc")
-        self.assertEqual(imms_fhir_resource["local_id"], "RSV_002^https://tpp-uk.com/Id/ve/vacc")
-
-    def test_process_row_successfully_uplifts_legacy_emis_uri(self):
-        """
-        Test that process_row gives the expected output.
-        These tests check that the row is valid and matches the expected output.
-        """
-        legacy_emis_row = deepcopy(ROW_DETAILS)
-        legacy_emis_row["UNIQUE_ID_URI"] = "YGJ"
-
-        expected_successful_result_emis = deepcopy(expected_successful_result)
-        expected_successful_result_emis["identifier"][0]["system"] = "https://emishealth.com/identifiers/vacc"
-
-        # call 'process_row' with required details
-        imms_fhir_resource = process_row(TargetDiseaseElements.RSV, Allowed_Operations, legacy_emis_row)
-        # validate if the response with expected result
-        self.assertDictEqual(imms_fhir_resource["fhir_json"], expected_successful_result_emis)
-        self.assertEqual(legacy_emis_row["UNIQUE_ID_URI"], "https://emishealth.com/identifiers/vacc")
-        self.assertEqual(imms_fhir_resource["local_id"], "RSV_002^https://emishealth.com/identifiers/vacc")
-
 
 if __name__ == "__main__":
     unittest.main()