VED-855: Low/Info priority Sonar maintainability issues (#1251)

Author: JamesW1-NHS

lambdas/ack_backend/src/update_ack_file.py

@@ -123,7 +123,7 @@ def create_ack_data(
             "Success" if successful_api_response else "Business Level Response Value - Processing Error"
         ),
         "RECEIVED_TIME": created_at_formatted_string,
-        "MAILBOX_FROM": "",  # TODO: Leave blank for DPS, use mailbox name if picked up from MESH mail box
+        "MAILBOX_FROM": "",  # VED-197 TODO: Leave blank for DPS, use mailbox name if picked up from MESH mail box
         "LOCAL_ID": local_id,
         "IMMS_ID": imms_id or "",
         "OPERATION_OUTCOME": diagnostics or "",

lambdas/mns_subscription/src/mns_setup.py

@@ -14,7 +14,7 @@ def get_mns_service(mns_env: str = "int"):
     boto_config = Config(region_name="eu-west-2")
     cache = Cache(directory="/tmp")
     logging.info("Creating authenticator...")
-    # TODO: MNS and PDS need separate secrets
+    # VED-1087 TODO: MNS and PDS need separate secrets
     authenticator = AppRestrictedAuth(
         service=Service.PDS,
         secret_manager_client=boto3.client("secretsmanager", config=boto_config),

lambdas/shared/src/common/ack_file_utils.py

@@ -28,8 +28,8 @@ def make_ack_data(
         "RESPONSE_CODE": ("20013" if (validation_passed and message_delivered) else "10002"),
         "RESPONSE_DISPLAY": (success_display if (validation_passed and message_delivered) else failure_display),
         "RECEIVED_TIME": created_at_formatted_string,
-        "MAILBOX_FROM": "",  # TODO: Leave blank for DPS, add mailbox if from mesh mailbox
-        "LOCAL_ID": "",  # TODO: Leave blank for DPS, add from ctl file if data picked up from MESH mailbox
+        "MAILBOX_FROM": "",  # VED-197 TODO: Leave blank for DPS, add mailbox if from mesh mailbox
+        "LOCAL_ID": "",  # VED-197 TODO: Leave blank for DPS, add from ctl file if data picked up from MESH mailbox
         "MESSAGE_DELIVERY": message_delivered,
     }
 

lambdas/shared/src/common/log_decorator.py

@@ -1,7 +1,6 @@
 """This module contains the logging decorator for sending the appropriate logs to Cloudwatch and Firehose.
 The decorator log pattern is shared by filenameprocessor, recordprocessor, ack_backend and id_sync modules.
 and therefore could be moved to a common module in the future.
-TODO: Duplication check has been suppressed in sonar-project.properties. Remove once refactored.
 """
 
 import json

lambdas/shared/src/common/models/fhir_immunization.py

@@ -33,7 +33,7 @@ def run_post_validators(immunization: dict, vaccine_type: str) -> None:
         if error := PostValidators(immunization, vaccine_type).validate():
             raise ValueError(error)
 
-    # TODO: Update this function as reduce_validation_code is no longer found in the payload after data minimisation
+    # VED-1086 TODO: Update this function as reduce_validation_code is no longer found in the payload after data minimisation
     @staticmethod
     def is_reduce_validation():
         """Identify if reduced validation applies (default to false if no reduce validation information is given)"""

lambdas/shared/src/common/models/field_locations.py

@@ -25,7 +25,7 @@ class FieldLocations:
     target_disease = "protocolApplied[0].targetDisease"
     target_disease_codes = f"protocolApplied[0].targetDisease[0].coding[?(@.system=='{Urls.SNOMED}')].code"
     patient_identifier_value = (
-        "contained[?(@.resourceType=='Patient')].identifier[0].value"  # TODO: Fix to use nhs number url lookup
+        "contained[?(@.resourceType=='Patient')].identifier[0].value"  # VED-1088 TODO: Fix to use nhs number url lookup
     )
     patient_name_given: str = field(init=False)
     patient_name_family: str = field(init=False)

sonar-project.properties

@@ -4,7 +4,6 @@ sonar.organization=nhsdigital
 sonar.host.url=https://sonarcloud.io
 sonar.python.version=3.11
 sonar.exclusions=**/proxies/**,**/utilities/scripts/**,**/infrastructure/account/**,**/infrastructure/instance/**,**/terraform_aws_backup/**,**/tests/**
-sonar.coverage.exclusions=lambdas/shared/src/common/models/batch_constants.py
 sonar.python.coverage.reportPaths=backend-coverage.xml,delta-coverage.xml,ack-lambda-coverage.xml,filenameprocessor-coverage.xml,recordforwarder-coverage.xml,recordprocessor-coverage.xml,mesh_processor-coverage.xml,redis_sync-coverage.xml,mns_subscription-coverage.xml,id_sync-coverage.xml,shared-coverage.xml,batchprocessorfilter-coverage.xml
 sonar.cpd.exclusions=**/Dockerfile
 sonar.issue.ignore.multicriteria=exclude_http_urls,exclude_writable_dirs,exclude_force_dict