Refactor GitHub Actions workflows for improved change detection and quality checks

- Updated change detection logic in `continuous-deployment.yml` and `pr-deploy-and-test.yml` to include `shared/src/common/` directory.
- Added a new job for quality checks in `pr-deploy-and-test.yml` to enhance code quality before deployment.
- Cleaned up whitespace in `deploy-backend.yml` for better readability.
- Minor update to error logging in `batch_processor.py` for clarity.

Author: Thomas-Boyle

.github/workflows/continuous-deployment.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Detect recordprocessor changes compared to master
         id: detect
         run: |
-          if git diff --name-only "${{ github.event.before }}" "${{ github.sha }}" | grep -q '^lambdas/recordprocessor/'; then
+          if git diff --name-only "${{ github.event.before }}" "${{ github.sha }}" | grep -Eq '^(lambdas/recordprocessor/|shared/src/common/)'; then
             echo "has_changes=true" >> "$GITHUB_OUTPUT"
           else
             echo "has_changes=false" >> "$GITHUB_OUTPUT"

.github/workflows/deploy-backend.yml

@@ -69,14 +69,11 @@ jobs:
       recordprocessor_image_tag: ${{ steps.build-image.outputs.recordprocessor_image_tag }}
     name: Build and push recordprocessor image
     runs-on: ubuntu-latest
-
     environment:
       name: ${{ inputs.environment }}
-
     env:
       AWS_REGION: eu-west-2
       SUB_ENVIRONMENT: ${{ inputs.sub_environment }}
-
     steps:
       - name: Checkout
         uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98

.github/workflows/pr-deploy-and-test.yml

@@ -9,6 +9,11 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  run-quality-checks:
+    uses: ./.github/workflows/quality-checks.yml
+    secrets:
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+
   detect-recordprocessor-changes:
     runs-on: ubuntu-latest
     if: github.event.action == 'synchronize'
@@ -25,17 +30,12 @@ jobs:
         run: |
           git fetch origin "${{ github.event.pull_request.base.ref }}"
 
-          if git diff --name-only "origin/${{ github.event.pull_request.base.ref }}" "${{ github.sha }}" | grep -q '^lambdas/recordprocessor/'; then
+          if git diff --name-only "origin/${{ github.event.pull_request.base.ref }}" "${{ github.sha }}" | grep -Eq '^(lambdas/recordprocessor/|shared/src/common/)'; then
             echo "has_changes=true" >> "$GITHUB_OUTPUT"
           else
             echo "has_changes=false" >> "$GITHUB_OUTPUT"
           fi
 
-  run-quality-checks:
-    uses: ./.github/workflows/quality-checks.yml
-    secrets:
-      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-
   deploy-pr-backend:
     needs: [run-quality-checks, detect-recordprocessor-changes]
     if: ${{ always() && !failure() && !cancelled() }}

lambdas/recordprocessor/src/batch_processor.py

@@ -31,7 +31,7 @@ def process_csv_to_fhir(incoming_message_body: dict) -> int:
         incoming_message_body["encoder"] = encoder
         interim_message_body = file_level_validation(incoming_message_body=incoming_message_body)
     except Exception as e:  # pylint: disable=broad-exception-caught
-        logger.error(f"File level validation failed: {e}")  # If the file is invalid, processing should cease
+        logger.error(f"File level validation failed: {e}")  # If the file is invalid, processing should cease.
         return 0
 
     file_id = interim_message_body.get("message_id")