Enhance CI workflows by refining change detection logic and re-enabling quality checks for PR deployments

Author: Thomas-Boyle

.github/workflows/continuous-deployment.yml

@@ -28,10 +28,10 @@ jobs:
       - name: Detect recordprocessor changes compared to master
         id: detect
         run: |
-          if git diff --name-only "${{ github.event.before }}" "${{ github.sha }}" | grep -q '^lambdas/recordprocessor/'; then
-            echo "has_changes=true" >> "$GITHUB_OUTPUT"
-          else
+          if git diff --quiet "${{ github.event.before }}" "${{ github.sha }}" -- lambdas/recordprocessor/ lambdas/shared/src/common/; then
             echo "has_changes=false" >> "$GITHUB_OUTPUT"
+          else
+            echo "has_changes=true" >> "$GITHUB_OUTPUT"
           fi
 
   deploy-internal-dev-backend:

.github/workflows/pr-deploy-and-test.yml

@@ -9,10 +9,10 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  # run-quality-checks:
-  #   uses: ./.github/workflows/quality-checks.yml
-  #   secrets:
-  #     SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  run-quality-checks:
+    uses: ./.github/workflows/quality-checks.yml
+    secrets:
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
   detect-recordprocessor-changes:
     runs-on: ubuntu-latest
@@ -35,7 +35,7 @@ jobs:
           fi
 
   deploy-pr-backend:
-    needs: [detect-recordprocessor-changes]
+    needs: [run-quality-checks, detect-recordprocessor-changes]
     if: ${{ always() && !failure() && !cancelled() }}
     uses: ./.github/workflows/deploy-backend.yml
     with: