rationalise logging

Author: nhsd-david-wass

lambdas/supplier-allocator/src/handler/allocate-handler.ts

@@ -32,10 +32,6 @@ function resolveSupplierForVariant(
   variantId: string,
   deps: Deps,
 ): SupplierSpec {
-  deps.logger.info({
-    description: "Resolving supplier for letter variant",
-    variantId,
-  });
   const supplier = deps.env.VARIANT_MAP[variantId];
   if (!supplier) {
     deps.logger.error({
@@ -135,13 +131,9 @@ async function getSupplierFromConfig(
       },
       volumeGroupId: volumeGroup.id,
     };
-    deps.logger.info({
-      description: "Resolved supplier details for letter event",
-      supplierDetails,
-    });
     return supplierDetails;
   } catch (error) {
-    deps.logger.error({
+    deps.logger.info({
       description: "Error fetching supplier from config",
       err: error,
       variantId: letterEvent.data.letterVariantId,
@@ -196,12 +188,6 @@ function incrementAllocation(
   allocation: number,
   deps: Deps,
 ) {
-  deps.logger.info({
-    description: "Incrementing allocation for volume group and supplier",
-    volumeGroupId,
-    supplierId,
-    allocation,
-  });
   const groupAllocations = map.get(volumeGroupId) ?? {};
   groupAllocations[supplierId] =
     (groupAllocations[supplierId] ?? 0) + allocation;
@@ -217,10 +203,6 @@ async function saveAllocations(
   deps: Deps,
   volumeGroupAllocations: VolumeGroupAllocation,
 ) {
-  deps.logger.info({
-    description: "Saving supplier allocations for volume groups",
-    volumeGroupAllocations,
-  });
   for (const [volumeGroupId, allocations] of volumeGroupAllocations) {
     for (const [supplierId, allocation] of Object.entries(allocations)) {
       await updateSupplierAllocation(

lambdas/supplier-allocator/src/services/supplier-config.ts

@@ -229,14 +229,6 @@ export async function filterPacksForLetter(
     ) {
       filteredPackIds.push(packSpecId);
     } else {
-      deps.logger.info({
-        description: "Evaluating pack specification constraints for letter",
-        letterVariantId: letterEvent.data.letterVariantId,
-        packSpecId,
-        pageCount: letterEvent.data.pageCount,
-        constraintValue: packSpec.constraints.sheets.value,
-        constraintOperator: packSpec.constraints.sheets.operator,
-      });
       const isValid = evaluateContraint(
         letterEvent.data.pageCount,
         packSpec.constraints.sheets.value,