correct test description. Remove unnecessary changes. Remove unused imports

Author: Vlasis-Perdikidis

.github/workflows/stage-1-commit.yaml

@@ -76,7 +76,7 @@ jobs:
     needs: detect-terraform-changes
     if: needs.detect-terraform-changes.outputs.terraform_changed == 'true'
     permissions:
-      contents: write
+        contents: write
     steps:
       - name: "Checkout code"
         uses: actions/checkout@v5
@@ -317,7 +317,7 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ inputs.nodejs_version }}
-          registry-url: "https://npm.pkg.github.com"
+          registry-url: 'https://npm.pkg.github.com'
 
       - name: check if local version differs from latest published version
         id: check-version

.gitleaksignore

@@ -1,4 +1,4 @@
-# SEE: https://github.com/gitleaks/gitleaks/blob/master/README.md#gitleaksignore
+# SEE: <https://github.com/gitleaks/gitleaks/blob/master/README.md#gitleaksignore>
 
 cd9c0efec38c5d63053dd865e5d4e207c0760d91:docs/guides/Perform_static_analysis.md:generic-api-key:37
 cd9c0efec38c5d63053dd865e5d4e207c0760d91:docs/guides/Perform_static_analysis.md:sonar-api-token:37
@@ -21,3 +21,5 @@ e12407e09151898bfd8d049d57eee9db9977d56b:.github/copilot-instructions.md:generic
 82cf3b2e89ea24b97c4ffc09e618700fb1b0aff3:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10
 82f6be3e657b46d8447e77cdc1894fba0b855c26:tests/component-tests/testCases/create-letter-request.spec.ts:generic-api-key:10
 debc75a97cfe551a69fd1e8694be483213322a9d:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10
+793b2ab7a3e698f5848fbe24d2718f88664ec0fc:.npmrc:npm-access-token:8
+793b2ab7a3e698f5848fbe24d2718f88664ec0fc:.npmrc:github-pat:6

tests/component-tests/apiGateway-tests/get-letter-status.spec.ts

@@ -30,7 +30,7 @@ test.describe("API Gateway Tests to Verify Get Letter Status Endpoint", () => {
       `${baseUrl}/${SUPPLIER_LETTERS}/${letter.id}`,
       {
         headers,
-      },
+      }
     );
 
     const responseBody = await response.json();

tests/component-tests/apiGateway-tests/testCases/update-letter-status.ts

@@ -41,7 +41,7 @@ export function patchRequestHeaders(): RequestHeaders {
 
 export function patchValidRequestBody(
   id: string,
-  status: string,
+  status: string
 ): PatchMessageRequestBody {
   let requestBody: PatchMessageRequestBody;
 
@@ -59,7 +59,7 @@ export function patchValidRequestBody(
 
 export function patchFailureRequestBody(
   id: string,
-  status: string,
+  status: string
 ): PatchMessageRequestBody {
   let requestBody: PatchMessageRequestBody;
 

tests/component-tests/apiGateway-tests/update-letter-status.spec.ts

@@ -45,7 +45,7 @@ test.describe("API Gateway Tests to Verify Patch Status Endpoint", () => {
       {
         headers,
         data: body,
-      },
+      }
     );
 
     expect(response.status()).toBe(202);
@@ -72,7 +72,7 @@ test.describe("API Gateway Tests to Verify Patch Status Endpoint", () => {
       {
         headers,
         data: body,
-      },
+      }
     );
 
     expect(response.status()).toBe(202);
@@ -92,7 +92,7 @@ test.describe("API Gateway Tests to Verify Patch Status Endpoint", () => {
       {
         headers,
         data: body,
-      },
+      }
     );
 
     const responseBody = await response.json();
@@ -113,7 +113,7 @@ test.describe("API Gateway Tests to Verify Patch Status Endpoint", () => {
       {
         headers,
         data: body,
-      },
+      }
     );
 
     const responseBody = await response.json();
@@ -133,7 +133,7 @@ test.describe("API Gateway Tests to Verify Patch Status Endpoint", () => {
       {
         headers,
         data: body,
-      },
+      }
     );
 
     const responseBody = await response.json();

tests/helpers/aws-sns-helper.ts

@@ -1,5 +1,4 @@
 import { SNSClient } from "@aws-sdk/client-sns";
 import { AWS_REGION } from "tests/constants/api-constants";
-import { logger } from "./pino-logger";
 
 export const snsClient = new SNSClient({ region: AWS_REGION });

tests/helpers/generate-fetch-test-data.ts

@@ -33,7 +33,7 @@ export interface SupplierApiLetters {
 
 export async function createTestData(
   supplierId: string,
-  count?: number,
+  count?: number
 ): Promise<void> {
   await runCreateLetter({
     filter: "nhs-notify-supplier-api-letter-test-data-utility",
@@ -50,7 +50,7 @@ export async function createTestData(
 export const getLettersBySupplier = async (
   supplierId: string,
   status: string,
-  limit: number,
+  limit: number
 ) => {
   const supplierStatus = `${supplierId}#${status}`;
   const params = {
@@ -78,13 +78,13 @@ export const deleteLettersBySupplier = async (id: string) => {
       TableName: LETTERSTABLENAME,
       Key: { supplierId: SUPPLIERID, id },
       ReturnValues: "ALL_OLD",
-    }),
+    })
   );
   return resp.Attributes;
 };
 
 export async function checkSupplierExists(
-  supplierId: string,
+  supplierId: string
 ): Promise<boolean> {
   try {
     const params = {

tests/helpers/pino-logger.ts

@@ -6,7 +6,7 @@ export const logger: pino.Logger = pino({
     options: {
       colorize: true,
       levelFirst: true,
-      translateTime: false, // disable time
+      translateTime: true,
       ignore: "pid,hostname,time",
     },
   },

tests/helpers/pnpm-helpers.ts

@@ -29,7 +29,7 @@ export async function runCreateLetter(options: {
 
   const workspaceRoot = path.resolve(
     __dirname,
-    "../../scripts/utilities/letter-test-data",
+    "../../scripts/utilities/letter-test-data"
   );
   const cmd = process.platform === "win32" ? "npm.cmd" : "npm";
   const root = path.resolve(workspaceRoot);
@@ -73,7 +73,7 @@ export async function runCreateLetter(options: {
     });
 
     child.on("close", (code) =>
-      code === 0 ? resolve() : reject(new Error(`pnpm exited with ${code}`)),
+      code === 0 ? resolve() : reject(new Error(`pnpm exited with ${code}`))
     );
     child.on("error", reject);
   });
@@ -91,7 +91,7 @@ export async function createSupplierData(options: {
 
   const workspaceRoot = path.resolve(
     __dirname,
-    "../../scripts/utilities/supplier-data",
+    "../../scripts/utilities/supplier-data"
   );
   const cmd = process.platform === "win32" ? "npm.cmd" : "npm";
   const root = path.resolve(workspaceRoot);
@@ -131,7 +131,7 @@ export async function createSupplierData(options: {
     });
 
     child.on("close", (code) =>
-      code === 0 ? resolve() : reject(new Error(`pnpm exited with ${code}`)),
+      code === 0 ? resolve() : reject(new Error(`pnpm exited with ${code}`))
     );
     child.on("error", reject);
   });

tests/helpers/validate-json-schema.ts

@@ -19,7 +19,7 @@ export default async function validateApiResponse(
   method: string,
   pathVar: string,
   status: number,
-  body: any,
+  body: any
 ): Promise<ValidationResult> {
   const openapiDoc = await import(paths);
 
@@ -36,7 +36,7 @@ export default async function validateApiResponse(
     operation.responses[status] || operation.responses.default;
   if (!responseSchema) {
     throw new Error(
-      `No schema defined for status ${status} at ${method.toUpperCase()} ${pathVar}`,
+      `No schema defined for status ${status} at ${method.toUpperCase()} ${pathVar}`
     );
   }