Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: stevebux

infrastructure/terraform/components/api/ddb_table_letter_queue.tf

@@ -12,7 +12,7 @@ resource "aws_dynamodb_table" "letter_queue" {
 
   local_secondary_index {
     name            = "queueSortOrder-index"
-    range_key       = "queueSortOrder-SK"
+    range_key       = "queueSortOrderSk"
     projection_type = "ALL"
   }
 
@@ -27,7 +27,7 @@ resource "aws_dynamodb_table" "letter_queue" {
   }
 
   attribute {
-    name = "queueSortOrder-SK"
+    name = "queueSortOrderSk"
     type = "S"
   }
 

internal/datastore/src/letter-queue-repository.ts

@@ -31,7 +31,9 @@ export default class LetterQueueRepository {
   ): Promise<PendingLetter> {
     // needs to be an ISO timestamp as Db sorts alphabetically
     const now = new Date().toISOString();
-    const priority = String(insertPendingLetter.priority ?? 10);
+    const priority = String(
+      insertPendingLetter.priority ?? this.defaultPriority,
+    );
     const queueSortOrderSk = `${priority.padStart(2, "0")}-${now}`;
     const pendingLetter: PendingLetter = {
       ...insertPendingLetter,

lambdas/upsert-letter/src/handler/upsert-handler.ts

@@ -21,7 +21,7 @@ type PreparedEvents = LetterRequestPreparedEventV2 | LetterRequestPreparedEvent;
 const SupplierSpecSchema = z.object({
   supplierId: z.string().min(1),
   specId: z.string().min(1),
-  priority: z.int(),
+  priority: z.int().min(0).max(99),
 });
 
 type SupplierSpec = z.infer<typeof SupplierSpecSchema>;