fix notfound error handling for getMI

Author: RossFaulds171

internal/datastore/src/mi-repository.ts

@@ -6,6 +6,7 @@ import {
 import { Logger } from "pino";
 import { randomUUID } from "node:crypto";
 import { MI, MISchema } from "./types";
+import MiNotFoundError from "./errors/mi-not-found-error";
 
 export type MIRepositoryConfig = {
   miTableName: string;
@@ -53,9 +54,7 @@ export class MIRepository {
     );
 
     if (!result.Item) {
-      throw new Error(
-        `Management Information with id ${miId} not found for supplier ${supplierId}`,
-      );
+      throw new MiNotFoundError(supplierId, miId);
     }
 
     return MISchema.parse(result.Item);

lambdas/api-handler/src/services/__tests__/mi-operations.test.ts

@@ -38,8 +38,19 @@ describe("postMI function", () => {
       },
     });
   });
+});
 
+describe("getMI function", () => {
   it("retrieves the MI from the repository", async () => {
+  const incomingMi: IncomingMI = {
+    lineItem: "envelope-business-standard",
+    timestamp: "2023-11-17T14:27:51.413Z",
+    quantity: 22,
+    specificationId: "spec1",
+    groupId: "group1",
+    stockRemaining: 20_000,
+    supplierId: "supplier1",
+  };
     const persistedMi = { id: "id1", ...incomingMi };
 
     const mockRepo = {
@@ -68,7 +79,7 @@ describe("postMI function", () => {
     const mockRepo = {
       getMI: jest
         .fn()
-        .mockRejectedValue(new MiNotFoundError("miId1", "supplier1")),
+        .mockRejectedValue(new MiNotFoundError("supplier1", "miId1")),
     };
 
     await expect(

lambdas/api-handler/src/services/mi-operations.ts

@@ -3,7 +3,7 @@ import { GetMIResponse, IncomingMI, PostMIResponse } from "../contracts/mi";
 import { mapToGetMIResponse, mapToPostMIResponse } from "../mappers/mi-mapper";
 import { ApiErrorDetail } from "../contracts/errors";
 import NotFoundError from "../errors/not-found-error";
-import MiNotFoundError from "@internal/datastore/src/errors/letter-not-found-error";
+import MiNotFoundError from "@internal/datastore/src/errors/mi-not-found-error";
 
 export const postMI = async (
   incomingMi: IncomingMI,