CCM-13194 Implement linting rules and typecheck (#343)

* letter test data utility auto fixes

* letter test data utility manual fixes

* gitleaksignore

* supplier data utility auto fixes

* supplier data utility manual fixes

* lambda fixes

* test auto fixes

* tests manual fixes

* CI typecheck and lint

* events fix

---------

Co-authored-by: Steve Buxton <steve.buxton@nhs.net>
Co-authored-by: Mark Slowey <mark.slowey1@nhs.net>

Author: 3 people

.github/workflows/stage-1-commit.yaml

@@ -1,5 +1,8 @@
 name: "Commit stage"
 
+permissions:
+  contents: read
+
 on:
   workflow_call:
     inputs:

.gitleaksignore

@@ -22,3 +22,4 @@ e12407e09151898bfd8d049d57eee9db9977d56b:.github/copilot-instructions.md:generic
 82f6be3e657b46d8447e77cdc1894fba0b855c26:tests/component-tests/testCases/create-letter-request.spec.ts:generic-api-key:10
 debc75a97cfe551a69fd1e8694be483213322a9d:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10
 777eb4047ad06b9e939a292ee18664a0ffee4f29:tests/resources/prepared-letter.json:generic-api-key:4
+4fa1923947bbff2387218d698d766cbb7c121a0f:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10

docs/package.json

@@ -14,6 +14,7 @@
     "build": "JEKYLL_ENV=production bundle exec jekyll build --trace --config _config.yml,_config.version.yml",
     "debug": "JEKYLL_ENV=development BUNDLE_GEMFILE=Gemfile bundle exec jekyll serve --config _config.yml,_config.dev.yml,_config.version.yml --limit_posts 100 --trace",
     "generate-includes": "./generate-includes.sh",
+    "lint": "echo \"Documentation module has no code to lint\"",
     "test:unit": "echo \"Documentation module has no unit tests\"",
     "typecheck": "echo \"Documentation module has no typescript to typecheck\""
   },

internal/events/package.json

@@ -50,5 +50,5 @@
     "typecheck": "tsc --noEmit"
   },
   "types": "dist/index.d.ts",
-  "version": "1.0.7"
+  "version": "1.0.8"
 }

internal/events/tsconfig.json

@@ -4,8 +4,7 @@
     "isolatedModules": true,
     "module": "commonjs",
     "outDir": "dist",
-    "resolveJsonModule": true,
-    "rootDir": "src"
+    "resolveJsonModule": true
   },
   "exclude": [
     "node_modules",
@@ -14,6 +13,7 @@
   "extends": "../../tsconfig.base.json",
   "include": [
     "src/**/*",
-    "package.json"
+    "package.json",
+    "jest.config.ts"
   ]
 }

lambdas/api-handler/package.json

@@ -7,6 +7,7 @@
     "@aws-sdk/s3-request-presigner": "^3.925.0",
     "@internal/datastore": "*",
     "@internal/helpers": "*",
+    "aws-lambda": "^1.0.7",
     "esbuild": "^0.25.11",
     "pino": "^9.7.0",
     "zod": "^4.1.11"

lambdas/api-handler/src/mappers/letter-mapper.ts

@@ -59,7 +59,7 @@ export function mapToUpdateCommands(
   request: PostLettersRequest,
   supplierId: string,
 ): UpdateLetterCommand[] {
-  return request.data.map( (letterToUpdate: PostLettersRequestResource) => ({
+  return request.data.map((letterToUpdate: PostLettersRequestResource) => ({
     id: letterToUpdate.id,
     supplierId,
     status: LetterStatus.parse(letterToUpdate.attributes.status),

lambdas/authorizer/package.json

@@ -3,6 +3,7 @@
     "@aws-sdk/client-dynamodb": "^3.858.0",
     "@aws-sdk/lib-dynamodb": "^3.858.0",
     "@internal/datastore": "*",
+    "aws-lambda": "^1.0.7",
     "esbuild": "^0.25.11",
     "pino": "^9.7.0",
     "zod": "^4.1.11"

lambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts

@@ -23,9 +23,9 @@ describe("letter-mapper", () => {
     $LetterEvent.parse(event);
     expect(event.type).toBe("uk.nhs.notify.supplier-api.letter.PRINTED.v1");
     expect(event.dataschema).toBe(
-      `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PRINTED.${event.dataschemaversion}.schema.json`
+      `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PRINTED.${event.dataschemaversion}.schema.json`,
     );
-    expect(event.dataschemaversion).toBe("1.0.7");
+    expect(event.dataschemaversion).toBe("1.0.8");
     expect(event.subject).toBe("letter-origin/supplier-api/letter/id1");
     expect(event.time).toBe("2025-11-24T15:55:18.000Z");
     expect(event.recordedtime).toBe("2025-11-24T15:55:18.000Z");

lambdas/upsert-letter/src/handler/upsert-handler.ts

@@ -47,7 +47,7 @@ function getOperationFromType(type: string): UpsertOperation {
           preparedRequest,
           supplierSpec.supplierId,
           supplierSpec.specId,
-          supplierSpec.specId, //use specId for now
+          supplierSpec.specId, // use specId for now
         );
         await deps.letterRepo.putLetter(letterToInsert);
       },
@@ -86,7 +86,7 @@ function mapToInsertLetter(
     subject: upsertRequest.subject,
     createdAt: now,
     updatedAt: now,
-    billingRef: billingRef,
+    billingRef,
   };
 }