Log errors but do not fail for new allocations

Author: nhsd-david-wass

lambdas/supplier-allocator/src/handler/__tests__/allocate-handler.test.ts

@@ -257,7 +257,7 @@ describe("allocate-handler", () => {
         () => {},
       )) as SQSBatchResponse;
 
-      expect(result.batchItemFailures).toHaveLength(1);
+      expect(result.batchItemFailures).toHaveLength(0);
       expect(deps.logger.error).toHaveBeenCalled();
     });
 

lambdas/supplier-allocator/src/handler/allocate-handler.ts

@@ -58,36 +58,45 @@ function validateType(event: unknown) {
 }
 
 async function getSupplierFromConfig(letterEvent: PreparedEvents, deps: Deps) {
-  const variantDetails: LetterVariant = await getVariantDetails(
-    letterEvent.data.letterVariantId,
-    deps,
-  );
-
-  const volumeGroupDetails: VolumeGroup = await getVolumeGroupDetails(
-    variantDetails.volumeGroupId,
-    deps,
-  );
-
-  const supplierAllocations: SupplierAllocation[] =
-    await getSupplierAllocationsForVolumeGroup(
+  try {
+    const variantDetails: LetterVariant = await getVariantDetails(
+      letterEvent.data.letterVariantId,
+      deps,
+    );
+
+    const volumeGroupDetails: VolumeGroup = await getVolumeGroupDetails(
       variantDetails.volumeGroupId,
       deps,
-      variantDetails.supplierId,
     );
 
-  const supplierDetails: Supplier[] = await getSupplierDetails(
-    supplierAllocations,
-    deps,
-  );
-  deps.logger.info({
-    description: "Fetched supplier details for supplier allocations",
-    variantId: letterEvent.data.letterVariantId,
-    volumeGroupId: volumeGroupDetails.id,
-    supplierAllocationIds: supplierAllocations.map((a) => a.id),
-    supplierDetails,
-  });
+    const supplierAllocations: SupplierAllocation[] =
+      await getSupplierAllocationsForVolumeGroup(
+        variantDetails.volumeGroupId,
+        deps,
+        variantDetails.supplierId,
+      );
+
+    const supplierDetails: Supplier[] = await getSupplierDetails(
+      supplierAllocations,
+      deps,
+    );
+    deps.logger.info({
+      description: "Fetched supplier details for supplier allocations",
+      variantId: letterEvent.data.letterVariantId,
+      volumeGroupId: volumeGroupDetails.id,
+      supplierAllocationIds: supplierAllocations.map((a) => a.id),
+      supplierDetails,
+    });
 
-  return supplierDetails;
+    return supplierDetails;
+  } catch (error) {
+    deps.logger.error({
+      description: "Error fetching supplier from config",
+      err: error,
+      variantId: letterEvent.data.letterVariantId,
+    });
+    return [];
+  }
 }
 
 function getSupplier(letterEvent: PreparedEvents, deps: Deps): SupplierSpec {