fix tests

Author: francisco-videira-nhs

tests/component-tests/apiGateway-tests/get-letter-pdf.spec.ts

@@ -7,10 +7,7 @@ import {
   SUPPLIER_LETTERS,
 } from "../../constants/api-constants";
 import { createValidRequestHeaders } from "../../constants/request-headers";
-import {
-  error404ResponseBody,
-  error500ResponseBody,
-} from "../../helpers/common-types";
+import { error404ResponseBody } from "../../helpers/common-types";
 
 let baseUrl: string;
 
@@ -84,7 +81,7 @@ test.describe("API Gateway Tests to Verify Get Letter PDF Endpoint", () => {
   });
 
   // CCM-14318: Remove this test
-  test(`Get /letters/{id}/data returns 500 if letter is not found for supplierId ${SUPPLIERID}`, async ({
+  test(`Get /letters/{id}/data returns 404 if letter is not found for supplierId ${SUPPLIERID}`, async ({
     request,
   }) => {
     const id = "non-existing-id-12345";
@@ -98,7 +95,7 @@ test.describe("API Gateway Tests to Verify Get Letter PDF Endpoint", () => {
     );
 
     const responseBody = await response.json();
-    expect(response.status()).toBe(500);
-    expect(responseBody).toMatchObject(error500ResponseBody());
+    expect(response.status()).toBe(404);
+    expect(responseBody).toMatchObject(error404ResponseBody());
   });
 });

tests/component-tests/apiGateway-tests/get-letter-status.spec.ts

@@ -3,10 +3,7 @@ import getRestApiGatewayBaseUrl from "../../helpers/aws-gateway-helper";
 import { getLettersBySupplier } from "../../helpers/generate-fetch-test-data";
 import { SUPPLIERID, SUPPLIER_LETTERS } from "../../constants/api-constants";
 import { createValidRequestHeaders } from "../../constants/request-headers";
-import {
-  error404ResponseBody,
-  error500ResponseBody,
-} from "../../helpers/common-types";
+import { error404ResponseBody } from "../../helpers/common-types";
 
 let baseUrl: string;
 
@@ -49,10 +46,10 @@ test.describe("API Gateway Tests to Verify Get Letter Status Endpoint", () => {
     });
   });
 
-  test(`Get /letters/{id} returns 404 if no resource is found for id`, async ({
+  test(`Get /letters/{id} returns 404 if letter is not found for supplierId ${SUPPLIERID}`, async ({
     request,
   }) => {
-    const id = "11";
+    const id = "non-existing-id-12345";
     const headers = createValidRequestHeaders();
     const response = await request.get(`${baseUrl}/${SUPPLIER_LETTERS}/${id}`, {
       headers,
@@ -62,18 +59,4 @@ test.describe("API Gateway Tests to Verify Get Letter Status Endpoint", () => {
     expect(response.status()).toBe(404);
     expect(responseBody).toMatchObject(error404ResponseBody());
   });
-
-  test(`Get /letters/{id} returns 500 if letter is not found for supplierId ${SUPPLIERID}`, async ({
-    request,
-  }) => {
-    const id = "non-existing-id-12345";
-    const headers = createValidRequestHeaders();
-    const response = await request.get(`${baseUrl}/${SUPPLIER_LETTERS}/${id}`, {
-      headers,
-    });
-
-    const responseBody = await response.json();
-    expect(response.status()).toBe(500);
-    expect(responseBody).toMatchObject(error500ResponseBody());
-  });
 });