finally get the pool of supplier details

Author: nhsd-david-wass

internal/datastore/src/supplier-config-repository.ts

@@ -11,6 +11,7 @@ import {
   LetterVariant,
   SupplierAllocation,
   VolumeGroup,
+  $Supplier, Supplier,
 } from "./SupplierConfigDomain";
 
 export type SupplierConfigRepositoryConfig = {
@@ -91,4 +92,21 @@ export class SupplierConfigRepository {
 
     return $SupplierAllocation.array().parse(result.Items);
   }
+
+  async getSuppliersDetails(supplierIds: string[]): Promise<Supplier[]> {
+    const suppliers: Supplier[] = [];
+    for (const supplierId of supplierIds) {
+      const result = await this.ddbClient.send(
+        new GetCommand({
+          TableName: this.config.supplierConfigTableName,
+          Key: { PK: "SUPPLIER", SK: supplierId },
+        }),
+      );
+      if (!result.Item) {
+        throw new Error(`Supplier with id ${supplierId} not found`);
+      }
+      suppliers.push($Supplier.parse(result.Item));
+    }
+    return suppliers;
+  }
 }

lambdas/supplier-allocator/src/handler/allocate-handler.ts

@@ -10,6 +10,7 @@ import { LetterRequestPreparedEventV2 } from "@nhsdigital/nhs-notify-event-schem
 import z from "zod";
 import {
   getSupplierAllocationsForVolumeGroup,
+  getSupplierDetails,
   getVariantDetails,
   getVolumeGroupDetails,
 } from "../services/supplier-config";
@@ -84,6 +85,14 @@ async function getSupplierFromConfig(letterEvent: PreparedEvents, deps: Deps) {
     description: "Fetched supplier allocations for volume group",
     supplierAllocations,
   });
+
+  const supplierDetails = await getSupplierDetails(supplierAllocations, deps);
+  deps.logger.info({
+    description: "Fetched supplier details for supplier allocations",
+    supplierDetails,
+  });
+
+  return supplierDetails;
 }
 
 function getSupplier(letterEvent: PreparedEvents, deps: Deps): SupplierSpec {

lambdas/supplier-allocator/src/services/supplier-config.ts

@@ -1,5 +1,6 @@
 import {
   LetterVariant,
+  Supplier,
   SupplierAllocation,
   VolumeGroup,
 } from "internal/datastore/src/SupplierConfigDomain";
@@ -118,3 +119,30 @@ export async function getSupplierAllocationsForVolumeGroup(
 
   return allocations;
 }
+
+export async function getSupplierDetails(
+  supplierAllocations: SupplierAllocation[],
+  deps: Deps,
+): Promise<Supplier[]> {
+  const supplierIds = supplierAllocations.map((alloc) => alloc.supplier);
+
+  const supplierDetails: Supplier[] =
+    await deps.supplierConfigRepo.getSuppliersDetails(supplierIds);
+
+  deps.logger.info({
+    description: "Fetched supplier details for supplier allocations",
+    supplierIds,
+    supplierDetails,
+  });
+
+  if (Object.keys(supplierDetails).length === 0) {
+    deps.logger.error({
+      description: "No supplier details found for supplier allocations",
+      supplierIds,
+    });
+    throw new Error(
+      `No supplier details found for supplier ids ${supplierIds.join(", ")}`,
+    );
+  }
+  return supplierDetails;
+}